Repository navigation
Add ACP v1 provider and generated OpenAPI contracts - #11
Merged
Merged
Conversation
kevinten10
marked this pull request as ready for review
October 9, 2026 08:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an ACP v1 subprocess Provider using the official SDK, with correlated human permissions,
explicit one-time versus remembered choices, bounded cancellation, disabled client filesystem and
terminal access, and isolated launch configuration. Model-free subprocess tests exercise both SDK
ends and negative protocol/process cases.
OpenAPI schemas are generated from the executable Zod contract. Independent JSON Schema checks
cover boundary samples and HTTP responses; network tests add invalid cursors and action responses.
Validation: local full checks passed 55 unit/contract tests and 35 integration tests, including
correlated permissions, bounded queues and teardown, malformed-envelope rejection without raw
logging, SDK parse-error recovery, and denied client filesystem/terminal requests. OpenAPI projection
equality and independent payload validation passed. Public-content scan and production dependency
audit passed. No private platform, production resource, or real model endpoint is used by these tests.