Skip to content

fix(deps): refresh vulnerable transitive dependencies - #606

Closed
Hanssen0-Alter-Ego wants to merge 3 commits into
ckb-devrel:devfrom
Hanssen0-Alter-Ego:fix/public-transitive-security-20261017
Closed

Hanssen0-Alter-Ego wants to merge 3 commits into
ckb-devrel:devfrom
Hanssen0-Alter-Ego:fix/public-transitive-security-20261017

Conversation

@Hanssen0-Alter-Ego

@Hanssen0-Alter-Ego Hanssen0-Alter-Ego commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Refresh transitive dependencies using their existing compatible ranges:

  • bn.js 4.12.2 → 4.12.3.
  • minimatch 3.1.2 → 3.1.5.
  • brace-expansion 1.1.12 / 5.0.7 → 1.1.21 / 5.0.12.

No dependency overrides are used. The legacy @typescript-eslint/typescript-estree@6.21.0 chain keeps its exact-pinned minimatch 9.0.3; the corresponding override and lockfile changes have been removed. Already-patched instances, direct dependency manifests, and all 28 workspace importer records remain unchanged.

Validation

  • The override-removal adjustment passes YAML parsing, exact base/head scope comparison, all 2,052 snapshot-reference checks, unchanged workspace-manifest/importer checks, and git diff --check.
  • Exact-head Build, lint and test passed for 0c769893, including build:all, lint, CJS/ESM smoke tests, and the repository test suite.
  • Fresh pinned pnpm 11.8.0 frozen lockfile-only verification passed all 2,036 supply-chain-policy entries after creating a new cache. No supply-chain policy was disabled. A full local build/lint/test rerun of the replacement head has not completed.

Remaining scope

The exact-pinned minimatch 9.0.3 advisory remains unresolved. The compatible minimatch 3.1.5 update is outside the official affected range, but a previously observed nested-extglob input still exceeds five seconds as on baseline 3.1.2; this PR does not claim every 3.x ReDoS case is behaviorally eliminated. Current copyfiles scripts use a fixed pattern.

Elliptic GHSA-848j-6mx2-7j84 also remains unresolved because the official advisory lists no patched version; updating bn.js does not fix it. KaTeX is left to #601. This is a bounded public-dependency update, not a verified inventory of every Dependabot alert, and production dependency presence does not establish vulnerable-method reachability.

Generated by ChatGPT · Alter Ego

Keep the minimatch override scoped to the legacy TypeScript ESLint consumer. Preserve existing majors and refresh the lockfile entries for bn.js, minimatch, and brace-expansion.

Generated by ChatGPT · Alter Ego
@changeset-bot

changeset-bot Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 3df275e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify

netlify Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for apiccc ready!

Name Link
🔨 Latest commit 3df275e
🔍 Latest deploy log https://app.netlify.com/projects/apiccc/deploys/6ad3cb37f7b8f5ab5b36b5a8
😎 Deploy Preview https://deploy-preview-606--apiccc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 84 (🔴 down 5 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 95 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for liveccc ready!

Name Link
🔨 Latest commit 3df275e
🔍 Latest deploy log https://app.netlify.com/projects/liveccc/deploys/6ad3cb37f4f501797f9e1adc
😎 Deploy Preview https://deploy-preview-606--liveccc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 10 (🔴 down 2 from production)
Accessibility: 88 (no change from production)
Best Practices: 92 (🔴 down 8 from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for docsccc ready!

Name Link
🔨 Latest commit 3df275e
🔍 Latest deploy log https://app.netlify.com/projects/docsccc/deploys/6ad3cb37303a7de877ef7544
😎 Deploy Preview https://deploy-preview-606--docsccc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 70 (🔴 down 22 from production)
Accessibility: 95 (no change from production)
Best Practices: 92 (🔴 down 8 from production)
SEO: 75 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Oct 17, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@netlify

netlify Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for appccc ready!

Name Link
🔨 Latest commit 3df275e
🔍 Latest deploy log https://app.netlify.com/projects/appccc/deploys/6ad3cb37d86798895241d17d
😎 Deploy Preview https://deploy-preview-606--appccc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 36 (🔴 down 26 from production)
Accessibility: 98 (🟢 up 1 from production)
Best Practices: 92 (🔴 down 8 from production)
SEO: 99 (🟢 up 11 from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Retain ordinary compatible dependency updates and restore the legacy exact-pinned minimatch dependency unchanged.

Generated by ChatGPT · Alter Ego
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant