Repository navigation
chore(deps): bump @libp2p/webrtc from 6.0.33 to 7.0.2 - #612
dependabot[bot] wants to merge 1 commit into
Conversation
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
❌ Deploy Preview for liveccc failed. Why did it fail? →
|
✅ Deploy Preview for docsccc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
❌ Deploy Preview for apiccc failed. Why did it fail? →
|
❌ Deploy Preview for appccc failed. Why did it fail? →
|
Hanssen0-Alter-Ego
left a comment
There was a problem hiding this comment.
Generated by ChatGPT · Alter Ego
| "@libp2p/identify": "^4.1.13", | ||
| "@libp2p/interface": "^3.3.0", | ||
| "@libp2p/webrtc": "^6.0.30", | ||
| "@libp2p/webrtc": "^7.0.2", |
There was a problem hiding this comment.
[P1] Update the libp2p component graph alongside WebRTC
With this lockfile, the normal pnpm build:all fails: WebRTC 7.0.2 resolves @libp2p/interface-internal@3.2.2, whose Registrar requires the new one-argument use(middleware) overload, while libp2p@3.3.11 still supplies the 3.1.13 registrar with only use(protocol, middleware). Consequently the unchanged webRTC() entry passed to createLibp2p in packages/connector/src/scenes/khie/node.ts:49 is incompatible (TS2322), blocking the connector and workspace build. The app dependency change has the same mismatch.
The head build reports this exact error; its checkout explicitly merges bdd02ef into d2a663d. The base build passes.
Coverage: Local validation passed the isolated lockfile audit and 16 mock behavior checks. A local full build and live transport integration were not run; the CI results cited above are observed remote evidence.
Suggested fix
Update and resolve the related libp2p/interface packages together so the node and transport share compatible component contracts, or retain WebRTC 6.0.33 until that coordinated update is ready. Upstream introduced global middleware in libp2p 3.4.0. Regenerate the lockfile and rerun the connector and app type checks plus pnpm build:all; do not hide the mismatch with a cast.
Generated by ChatGPT · Alter Ego
Bumps [@libp2p/webrtc](https://github.com/libp2p/js-libp2p) from 6.0.33 to 7.0.2. - [Release notes](https://github.com/libp2p/js-libp2p/releases) - [Commits](libp2p/js-libp2p@daemon-v6.0.33...utils-v7.0.2) --- updated-dependencies: - dependency-name: "@libp2p/webrtc" dependency-version: 7.0.2 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
bdd02ef to
1873740
Compare

Bumps @libp2p/webrtc from 6.0.33 to 7.0.2.
Release notes
Sourced from @libp2p/webrtc's releases.
... (truncated)
Commits
e626e2echore: release main (#3313)334f91bchore: skip mdns tests in CIe10c5c0fix: update error logs to use %e token (#3261)8d66d5ffix: capture early datachannels (#3312)d04c539chore: release main (#3311)39e2e54fix: remove pipe from floodsub (#3310)8543df0fix: remove it-ws (#3309)6f466c6chore: release main (#3307)425a42cfix: use@chainsafe/libp2p-noiseand@chainsafe/libp2p-yamux(#3308)71e8ee1fix: bump noise version (#3306)