Repository navigation
Cosmetic cleanup: (DC2Type) column comments, UiOptions PHPDoc - #128
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…AL 3 uses them Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #127
(DC2Type:...)column commentsNew
Version20261008120000migration (the released migrations are not modified):(DC2Type:json)/(DC2Type:datetime_immutable)comment (log_record.context,log_record.created_at,process_execution.start_date,end_date,report,process_schedule.context,process_user.roles) are modified without comment.COMMENT ON COLUMN ... IS NULLonlog_record.created_at,process_execution.start_date,end_date.Configuration::getDisableTypeComments(), alwaystruewith DBAL 4,falseby default with DBAL 3 (disable_type_commentsoption). With DBAL 3 using the type comments, the migration does nothing: they are still needed (types read from the comments, e.g.datetime_immutable).down()restores the comments, with the same condition.Limit: an application that runs this migration with DBAL 3 (type comments used) and upgrades to DBAL 4 later keeps the comments, as its own tables: the DBAL 4 upgrade procedure (
doctrine:migrations:diff) removes them.UiOptionsPHPDoc'run': ?bool(was the string literal'null|bool'),'context': array<array{'key': int|string, 'value': int|string}>(wasarray{array{'key': 'int|text', ...}}).Checks (DBAL 4.5)
doctrine:schema:update --dump-sql, statements on the bundle tables:updownupagainDBAL 3:
Configuration::getDisableTypeComments()checked in the DBAL 3.10 and 4.4 sources (lower bounds of^3.10 || ^4.4); not run on a DBAL 3 installation.PHPStan, PHP-CS-Fixer, Rector OK; PHPUnit OK (no migration unit test, as agreed).
🤖 Generated with Claude Code