Repository navigation
Conversation
Build dependency keys and detect trimmed dependencies in one traversal. Remove redundant writer state and validate job packages as their manifests are read. Use Ginkgo tables, explicit fixtures and gstruct assertions; consolidate archive test helpers. Preserve existing identity vectors and keep the complete non-vendored production diff within 300 changed lines.
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Restore the original job archive validation path and explicit trimming option. Keep external FIXTURES discovery alongside the committed table entries, and name fingerprint payload components for readability. Add regression cases for empty manifests and validation order. The complete non-vendored production diff is 319 changed lines under the approved 320-line budget.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies #496 while preserving its opt-in behavior and package identities. Targets Chris's
feature/compile-time-packagesbranch.Dependency-key generation and dropped-dependency detection share one traversal. The writer uses the manifest's source packages directly and retains an explicit trimming option. Job archive validation is unchanged from #496.
Review feedback is addressed with Ginkgo tables, gstruct assertions, and shared archive test helpers. The fixture suite runs both committed fixtures and every tarball supplied through
FIXTURES.Production diff against #496's merge base: 306 added + 13 removed = 319 changed lines, excluding vendor files and tests.
Validation:
go test -race -tags fixtures ./releasetarball ./mainpassed, including new validation regression cases.git diff --checkpassed.