Skip to content

fix(observability): scope the "All" of the cluster and server variables - #496

Merged
gabriele-wolfox merged 6 commits into
cloudnative-pg:dev/461from
joao00001:dev/461-suggestions
Oct 26, 2026
Merged

gabriele-wolfox merged 6 commits into
cloudnative-pg:dev/461from
joao00001:dev/461-suggestions

Conversation

@joao00001

Copy link
Copy Markdown

Suggestions from the review of #475:

  • Scope the "All" value of the cluster and server variables, which still matched clusters and servers from other namespaces.
  • List the clusters of servers that receive no WAL in the "Served cluster" variable
  • Update the validation steps of the multi sample for the two dashboards
  • Show the Klio server in the legend of the retained backups panel (first review comment). The includeVars part of that comment is not included, since it would carry namespace and cluster across dashboards where they mean different things

On the Klio Clusters dashboard, selecting a namespace and leaving the
cluster variable on "All" still showed every cluster on the panels
built from the Klio server metrics, because "All" matched any value
(`.+`) instead of the clusters of the selected namespace. The server
variable of the Klio Servers dashboard had the same problem with the
servers.

Let "All" expand to the values listed by these two variables, which
are already filtered by their parents. The other variables keep
matching any value.

Source the clusters listed by the "Served cluster" variable from all the
Klio server metrics, so a server that does not receive WAL, such as a
read-only one, still lists the clusters it serves.

Signed-off-by: Joao Detomini <joao.detomini@enterprisedb.com>
…sample

The validation steps still described the single dashboard. Split them
between the Klio Clusters and the Klio Servers dashboards, and add the
checks for the "All" value of the cluster and server variables.

Also fix what the sample README said about the server variable: it
matches the OpenTelemetry service.name, which the multi sample sets
differently for each server, so the two independent klio-a servers are
not conflated.

Signed-off-by: Joao Detomini <joao.detomini@enterprisedb.com>
The Klio Clusters dashboard did not tell which Klio server retains the
backups of a cluster. Group the retained backups panel by server too,
and show the server in its legend. The same panel on the Klio Servers
dashboard gets the same legend.

Signed-off-by: Joao Detomini <joao.detomini@enterprisedb.com>
… time range

Now that "All" of the cluster and server variables expands to the listed
values, a cluster or server that appears after the dashboard loads stays
out of every panel until the page is reloaded. Refresh both variables when
the time range changes, which also happens at every auto-refresh.

Assisted-by: Claude

Signed-off-by: Gabriele Quaresima <gabriele.quaresima@enterprisedb.com>
Two servers reading the same repository, such as a read-only one, both
report its snapshots, so the Retained snapshots panel counted them twice.
Group it by server too, as the Retained backups panel already does, and
widen the Kopia snapshot tiles so the longer legend fits.

Assisted-by: Claude

Signed-off-by: Gabriele Quaresima <gabriele.quaresima@enterprisedb.com>
Capture the Klio Clusters and Klio Servers dashboards again after the
changes to the variables and the per-server snapshot panel.

Assisted-by: Claude

Signed-off-by: Gabriele Quaresima <gabriele.quaresima@enterprisedb.com>
@gabriele-wolfox
gabriele-wolfox merged commit ec850db into cloudnative-pg:dev/461 Oct 26, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants