Repository navigation
Conversation
Author
|
Closing this upstream proposal. We will keep the implementation internal for now. |
Contributor
|
Thanks for this proposal. Sparse S3 checkpoints are now in main through #364: export files are split into 16 MiB SHA-256 chunks, holes are skipped with SEEK_DATA/SEEK_HOLE, all-zero chunks are never uploaded, and a fetch recreates the file at full size, writing only present chunks. It differs from this PR in two ways: chunks are deduplicated across a claim's checkpoints, archives and replicas, and the old dense layout is not kept readable (the upgrade note in docs/deploy.md covers this). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
checkpoint_store.s3.sparseformat for checkpoint recordsPromoted templates keep their existing digested dense representation; this change targets checkpoint/archive records whose logical raw disk size can be much larger than allocated data.
Storage format
A sparse generation stores ordinary dense files unchanged plus:
.sandboxd-sparse-v1/manifest.json.sandboxd-sparse-v1/chunks/<path-hash>/<index>Each chunk packs up to 64 MiB of allocated extents, avoiding one-object-per-extent explosions.
meta.jsonremains the final commit marker. Fetch supports both old dense generations and the new manifest format.Rollout
Deploy this reader to every sandboxd node first, then enable
"sparse": truecluster-wide. Older sandboxd versions do not understand generations written in the new format.Verification
go test -race ./...insandboxdGOOS=linux golangci-lint run ./...