Skip to content

Fix tickets not creating when the bot lacks Administrator #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Verslabs wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix tickets not creating when the bot lacks Administrator #236

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions src/services/ticket.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,35 @@ const TICKET_DELETE_DELAY_MS = 3000;
const TICKET_DELETE_DELAY_SECONDS = Math.floor(TICKET_DELETE_DELAY_MS / 1000);
const TICKET_SERVICE = 'ticketService';

// Ticket categories and channels deny @everyone ViewChannel, so the bot needs its own
// overwrite. Without one, Discord rejects the member overwrites on the ticket channel
// (a bot can only grant permissions it has in the parent) and the bot cannot post in it.
const BOT_TICKET_PERMISSIONS = [
PermissionFlagsBits.ViewChannel,
PermissionFlagsBits.SendMessages,
PermissionFlagsBits.EmbedLinks,
PermissionFlagsBits.AttachFiles,
PermissionFlagsBits.ReadMessageHistory,
];

// Repairs "Tickets" categories created before the bot overwrite existed.
async function ensureBotCanAccessCategory(category, botMember) {
if (!category || !botMember) return;
if (category.permissionsFor(botMember)?.has(BOT_TICKET_PERMISSIONS)) return;

try {
await category.permissionOverwrites.edit(botMember.id, {
ViewChannel: true,
SendMessages: true,
EmbedLinks: true,
AttachFiles: true,
ReadMessageHistory: true,
});
} catch (error) {
logger.warn(`Could not grant bot access to ticket category ${category.id}: ${error.message}`);
}
}

function ticketUserError(message, userMessage, type = ErrorTypes.VALIDATION, context = {}) {
throw createError(message, type, userMessage, { service: TICKET_SERVICE, ...context });
}
Expand Down Expand Up @@ -112,8 +141,14 @@ export async function createTicket(guild, member, categoryId, reason = 'No reaso
id: guild.id,
deny: [PermissionFlagsBits.ViewChannel],
},
{
id: guild.members.me.id,
allow: BOT_TICKET_PERMISSIONS,
},
],
});
} else {
await ensureBotCanAccessCategory(category, guild.members.me);
}

const ticketNumber = await getNextTicketNumber(guild.id);
Expand All @@ -136,6 +171,10 @@ export async function createTicket(guild, member, categoryId, reason = 'No reaso
id: guild.id,
deny: [PermissionFlagsBits.ViewChannel],
},
{
id: guild.members.me.id,
allow: BOT_TICKET_PERMISSIONS,
},
{
id: member.id,
allow: [
Expand Down