Repository navigation
fix: join base url and relative path with a single slash - #5738
Merged
Merged
Conversation
Playwright amOnPage produced https://host/app///path whenever the base url ended with a slash, and Puppeteer/WebDriver concatenated without any separator. Route all of them through appendBaseUrl and fix its trimUrl, which never stripped the leading slash. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
DenysKuchma
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Playwright.amOnPagebuilt the URL as:When the base url ends with
/, it always adds another/:urlconfigamOnPage(...)https://todomvc.com/examples/react/dist//…/dist///…/dist/https://todomvc.com/examples/react/dist//#/active…/dist///#/active…/dist/#/activehttps://todomvc.com/examples/react/dist/index.html…/dist//index.html…/dist/index.htmlPuppeteer.amOnPage, Playwright's API request method and WebDriver's basic-auth branch concatenated base and path directly, giving//or no separator at all (http://hostlogin).Fix
All four now use the existing
appendBaseUrlutil fromlib/utils.js. ItstrimUrlnever stripped the leading slash (url.substr(1) === '/'only matched two-character inputs), so that is fixed too, and trailing slashes on the base are all removed.Tests
#appendBaseUrlcases intest/unit/utils_test.js.🤖 Generated with Claude Code