Repository navigation
fix(pause): ignore step failures inside tryTo and retryTo - #5741
Merged
Merged
Conversation
Effects track how many are active; pause on=fail skips step failures while tryTo or a retryTo attempt that will be retried is running. Fixes #4516 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4516. Alternative to #5736.
With
-p pause(on=fail), a step that failed insidetryToorretryTopaused the test even when the test passed.Instead of switching the trigger to
test.failed, the effects now track whether they are active:lib/effects.jskeeps anactiveEffectscounter and exportsisEffectActive().tryTocounts for its whole run;retryTocounts only attempts that will be retried, so a failure on the last attempt still pauses. The counter resets ontest.before.lib/plugin/pause.jsignoresstep.failedwhileisEffectActive()is true.tryToretryTopasses on a later attemptretryTouses up all attemptshopeThatsoft assertion failsBeforeorAfterthrowwithout a failed stepTests:
test/unit/plugin/pause_test.js(based on the one from #5736) covers these cases.Known unrelated issue: a step failing inside
withininsidetryTogets pasttryToand fails the test; this happens on 4.x without this change.🤖 Generated with Claude Code