Repository navigation
fix(deps): bump axios, @xmldom/xmldom and mocha to patched versions - #5752
Merged
Merged
Conversation
Closes #5731. mocha 12 pulls serialize-javascript 7 (GHSA-5c6j-r48x-rmvq, GHSA-qj8w-gfj5-8c6v). Uses caret ranges so patch releases flow through. mocha 12 is ESM with named exports, so internal imports were updated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
DenysKuchma
approved these changes
Oct 13, 2026
The mocha adapter uses Mocha.utils.inherits, removed in mocha 12. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5731
Bumps dependencies that had high-severity advisories, and switches them to caret ranges so patch releases reach users:
axios1.16.1 →^1.20.0@xmldom/xmldom0.9.10 →^0.9.12mocha11.7.5 →^12.0.3, which pulls inserialize-javascript@7.1.2(GHSA-5c6j-r48x-rmvq, GHSA-qj8w-gfj5-8c6v)We had to move to mocha 12:
overridesdon't apply to consumers, and mocha 11.x still depends on serialize-javascript 6. The Node engine (>=22.12.0) already meets mocha 12's requirement.mocha 12 is ESM with named exports only, so the internal imports in
lib/mocha/*and the unit tests now useimport { Suite, Test, reporters } from 'mocha'and{ createCommon }. This also fixescommon.runWithSuite→cmn.runWithSuiteinui.js.Local results: unit tests 895 passing, runner tests 314 passing, tsd clean.
🤖 Generated with Claude Code