Repository navigation
fix(webdriver): click iOS elements with the W3C elementClick command - #5757
Open
elliotsabitov wants to merge 1 commit into
Open
elliotsabitov wants to merge 1 commit into
elliotsabitov wants to merge 1 commit into
Conversation
click, checkOption and uncheckOption called the JSON Wire touchClick command on non-Android mobile sessions. webdriverio 9 deprecates it and webdriverio 10 removes it. elementClick is the W3C command the helper already uses on Android and desktop, and Appium XCUITest supports it.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation/Description of the PR
click,checkOptionanduncheckOptionnow usebrowser.elementClickon every platform. iOS sessions went through the JSON WiretouchClickcommand, which webdriverio 9 deprecates and webdriverio 10 removes. Android and desktop sessions already usedelementClick, so only iOS behaviour changes.Tested on AWS Device Farm with our iOS Safari journey suite (iPhone 16, iOS 18.0, Appium XCUITest, webdriverio 9.32, CodeceptJS 4.2.1) with this change applied. All 12 scenarios passed, every
I.clickwent throughelementClick, and the deprecation notice no longer appears. An unpatched run of the same setup printed it 22 times per device.Applicable helpers:
Type of change
Checklist:
npm run lint)npm run test:unit, 895 passing)