Repository navigation
Conversation
A valid token must open the unblock view and nothing else: other tasks or components (also in other spellings) and non-string tokens stay blocked, and the token of another address's block is no pass. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LhhhdjhErC9ZiaS4HyRjsh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two integration tests to
BlockedRequestTestfor the unblock-token exemption:testUnblockTokenPassIsLimitedToTheUnblockView: with a valid token, requests with another task or component (includingtask=user.LOGIN,option=com_login), upper-caseoption/view, or an array-valuedtokenstay blocked; onlyoption=com_bfstop&view=tokenunblockpasses.testUnblockTokenOfAnotherAddressIsNoPassForTheUnblockView: a valid token of another address's block doesn't open the unblock view.The expected outcomes were observed with
tests/Integration/fixtures/request.phpagainst Joomla 5.4.8 on PostgreSQL. The new tests are syntax-checked but were not run under PHPUnit (not available in the session).No production code is changed.
🤖 Generated with Claude Code
https://claude.ai/code/session_01LhhhdjhErC9ZiaS4HyRjsh
Generated by Claude Code