Conversation
stirby
added a commit
that referenced
this pull request
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
golang.org/x/crypto0.45.0 to 0.56.0 andgolang.org/x/net0.47.0 to 0.57.0 (x/textfollows). govulncheck: 75 reachable to 61, fixing 14.These are reachable through
git.CloneRepousingssh.NewClientConnfor git over SSH. The client-side ones (panics, DoS on crafted server responses) are the ones envbuilder actually exercises. Several advisories are SSH server-side and are only reachable from test helpers (gittest.NewServerSSH).Note:
x/crypto0.56.0 requiresgo 1.26.0, so thegodirective moves from 1.24.10 to 1.26.0. CI usessetup-gowith~1.22, and it relies onGOTOOLCHAIN=autoto fetch 1.26. Please confirm CI does this. If it does not, the workflowgo-versionneeds updating, or use x/crypto 0.52.0 (go 1.25), which still fixes 9 of the 14.GO-2026-5026 (Punycode) needs both this PR and the Go 1.26.6 toolchain PR.
Part of a set of independent dependency PRs. All touch
go.mod/go.sum, so rebase withgo mod tidyafter the first one merges.Generated by Coder Agents on behalf of @stirby.