Repository navigation
test(Table): drop explicit zoneless provider, unique ancestor selector - #308
Merged
Merged
Conversation
createApplication is zoneless by default, so the provider was redundant. With a stray zone.js in node_modules it also logged NG0914.
ToggleTestComponent and AncestorTestComponent hashed to the same component ID under the default ng-component selector (NG0912).
xidedix
added a commit
that referenced
this pull request
Oct 19, 2026
- fix(alert): hide and emit `visibleChange` when there is no opacity transition (#304) - fix(carousel): measure each swipe from its own touchstart (#303) - fix(collapse.directive): emit `visibleChange` and `collapseChange` when `animate` is false (#292) - fix(dropdown): mirror the menu placement in a right-to-left context (#299) - fix(dropdown, modal, offcanvas): Escape in an open dropdown leaves the container open (#298) - fix(shadow-on-scroll.directive): changing `cShadowOnScroll` drops the old shadow class and scroll listener (#292) - fix(sidebar): apply input changes after first render, scope state actions to their sidebar (#307) - fix(sidebar-nav): apply multi-class item classes, style the label as a nav link (#309) - fix(sidebar-nav-helper): `isActive()` handles array urls (#296) - fix(sidebar-nav-icon.pipe): handle a missing item (#296) - fix(table): keep one responsive wrapper and remove it on destroy (#305) - fix(tabs): Home/End, one key manager, navigate and select by key (#306) - fix: ignore key events without a key (#302) - refactor(tab-pane): `OnPush`, signal state, host metadata (#294) - refactor: drop `ngAcceptInputType_` from signal inputs (#293) - test: run specs zoneless, drop `zone.js` (#295) - test: use `TestBed.createDirective()` in directive specs (#292) - test: cover untested paths across components and services (#300, #301, #308) - ci: bump `actions/setup-node` (#297) - chore(dependencies): update to Angular 22.2.3 (#310) Verified: `npm ci`, lint, tests 30 + 1035 + 60, 3 prod builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createApplication is zoneless by default, so the explicit provideZonelessChangeDetection() in the table spec was redundant; with a stray zone.js in node_modules it also logged NG0914.
ToggleTestComponent and AncestorTestComponent hashed to the same component ID under the default ng-component selector (NG0912). The ancestor component gets its own selector.