Repository navigation
Allow application-defined auditing of normalized gitignore segments - #153
Open
sricharanreddycheruku wants to merge 1 commit into
Open
sricharanreddycheruku wants to merge 1 commit into
sricharanreddycheruku wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #131: implements the maintainer's suggested optional segment-auditing
hook without imposing hard-coded limits on normal patterns.
Add an overridable _audit_segments() class method to both gitignore pattern
classes. Existing PathSpec/GitIgnoreSpec pattern_factory arguments let applications
supply an audited subclass. The hook receives an immutable tuple after normalization
and before regex translation, including optimized regex-override patterns. Comments,
null patterns and precompiled expressions are not audited. Rejection exceptions
propagate unchanged regardless of the pattern-notation errors policy.
Document a subclass example and the hook's limitations: a wildcard-count policy is
application-defined and does not guarantee bounded matching time. Update API docs,
change history and strict typed-usage examples.
Validation:
original source report 53 failures (including subtests), with 19 passing controls.
238 passed, 1 skipped, 974 subtests passed on each.
Targeting Python 3.12 reports existing _typing.py fallback errors; the same mypy
errors are reproduced on unchanged upstream source.