Repository navigation
Avoid following symlink targets when link traversal is disabled - #156
Open
sricharanreddycheruku wants to merge 1 commit into
Open
sricharanreddycheruku wants to merge 1 commit into
sricharanreddycheruku wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iter_tree_files(..., follow_links=False)still follows symbolic link targetswhen it calls
DirEntry.is_file()with the defaultfollow_symlinks=True.A self-referential link or a two-link cycle consequently raises
ELOOPandaborts traversal, although link following was disabled.
Pass the existing
follow_linksoption to the file-type check, matching thepreceding directory-type check. Unfollowed links can then reach the existing
symlink-yield branch without inspecting their targets. The default following
behavior is unchanged.
Add real-filesystem regressions for both link cycles, checking that the links,
ordinary files, and nested files are all returned without an error callback.
Update the changelog source and its rendered copies.
Validation on Linux:
ELOOP.with the optional native backends installed.
backend cases are skipped (391 skips including subtest skips).
git diff --checkpass.No linked issue. This is independent of the pending gitignore matching changes.
Windows and macOS were not run locally.