Skip to content

chore(dev): drop python v3.10 from dev workflow - #516

Merged
2bndy5 merged 1 commit into
mainfrom
drop-py-3.10
Oct 29, 2026
Merged

2bndy5 merged 1 commit into
mainfrom
drop-py-3.10

Conversation

@2bndy5

@2bndy5 2bndy5 commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

The action itself still uses the python v3.12 (as specified in .python-version file).

This also removes the constraint on some transitive dependencies (used only in dev workflows) that have security alerts. I have also updated the uv.lock file to resolve said security alerts.

Related Issues

This is related to (and reverts) the hack in #514 where pre-commit was limited to actively supported python versions.

Summary by CodeRabbit

  • Compatibility
    • Python 3.11 or later is now required. Python 3.10 is no longer supported, so upgrade your Python installation before updating the project.
  • Development
    • The project’s pre-commit tooling can now be used without a Python 3.11 minimum. This does not change the Python version required to run the project.

@2bndy5 2bndy5 changed the title chore(dev: drop python v3.10 from dev workflow chore(dev): drop python v3.10 from dev workflow Oct 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-format (v16.0.6) reports: 2 file(s) not formatted
  • docs/examples/demo/demo.cpp
  • docs/examples/demo/demo.hpp
clang-tidy (v16.0.6) reports: 7 concern(s)

✨ Powered by cpp-linter -- ⭐ Star • ❤️ Sponsor • 💬 Feedback

The action itself still uses the python v3.12 (as specified in .python-version file).

This also removes the constraint on some transitive dependencies (used only in dev workflows) that have security alerts. I have also updated the uv.lock file to resolve said security alerts.

This is related to (and reverts) the hack in #514 where pre-commit was limited to actively supported python versions.
@2bndy5
2bndy5 marked this pull request as ready for review October 29, 2026 09:14
@2bndy5
2bndy5 requested a review from a team as a code owner October 29, 2026 09:14
@coderabbitai

coderabbitai Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 98338240-374a-4b40-801b-8f251e4ddc52
Commits

Reviewing files that changed from the base of the PR and between 3992b4c and 7078665.

Files ignored due to path filters: 1
  • uv.lock is excluded by !**/*.lock
Files selected for processing: 1
  • pyproject.toml

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

Walkthrough

The project now requires Python 3.11 or later. The pre-commit development dependency no longer has a Python-version marker.

Changes

Python version configuration

Layer / File(s) Summary
Update Python project metadata
pyproject.toml
The minimum Python version changes from 3.10 to 3.11. The pre-commit Python-version marker and its explanatory comment are removed.

Priority: Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Possibly related PRs

  • cpp-linter/cpp-linter-action#514: Added the Python 3.11 condition for pre-commit while retaining Python 3.10 support; this change removes that condition and raises the project minimum to Python 3.11.
Merge Risk: Minimal · up to 70786

The Python version requirement update is consistent with the supplied project configuration.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: removing Python 3.10 from the development workflow.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@2bndy5
2bndy5 merged commit f45b3f8 into main Oct 29, 2026
45 checks passed
@2bndy5
2bndy5 deleted the drop-py-3.10 branch October 29, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants