Skip to content

Use CondSend / CondSync #4

Closed
#18
Closed
Use CondSend / CondSync#4
#18

Description

@DougAnderson444
DougAnderson444
opened on Apr 19, 2025

bs/crates/content-addressable/src/block.rs

Line 6 in fa0cfc8

pub trait Block<'a, K>: Send + Sync {

You may want to make these conditional, so that the Send bound is not present for wasm targets.

This may be important when block are stored in browser storage or other non-native interface

See this example:
https://github.com/eigerco/blockstore/blob/main/src/cond_send.rs

Activity

  1. dhuseby commented on Apr 22, 2025

    @dhuseby
    dhuseby
    on Apr 22, 2025
    Member

    I like this. I'll set up a PR ASAP.

  2. DougAnderson444 commented on Oct 27, 2025

    @DougAnderson444
    DougAnderson444
    on Oct 27, 2025
    CollaboratorAuthor

    This is implemented in #18

  3. DougAnderson444
    closed this as completedin #18on Nov 4, 2025
  4. mikelodder7
    added a commit that references this issue on Jan 30, 2026

    Major upgrade from WACC to Comrade DSL, added bs-p2p, bs-peer, all th…

    82640d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions