Repository navigation
Fix windows ci - #321
Open
mbraendli wants to merge 2 commits into
Open
Fix windows ci#321mbraendli wants to merge 2 commits into
mbraendli wants to merge 2 commits into
Conversation
run-windows.ps1 only builds the library, examples and tests are off, so the Windows build never runs Cucumber. Installing the Ruby gems fails since sys-uname 1.5.1 pulls in win32ole on Windows, whose native extension does not build on the runner. Assisted-by: Claude Code
v3.5.0 runs on Node.js 20, which GitHub has deprecated. The runner forces it onto Node.js 24 and warns in every Windows job. Assisted-by: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removed unused Ruby workflow step that was causing Windows build failures. Updated actions/cache from v3.5.0 to v6.1.0 to resolve Node.js 20 warnings. Analysis, implementation, and tests were realized with Claude Code. Manual tests and reviews were done for all changes.
Details
The changes include:
run-windows.ps1only builds the library, Examples and Tests areOFF.sys-uname 1.5.1on Windows pulls inwin32olewhose native extension doesn't build on the runner.adhoc-packages).Motivation and Context
The pipeline needs to be green to get another Pull Request (#320) through. The Windows build was failing due to the unused Ruby step.
How Has This Been Tested?
Types of changes
Checklist: