Repository navigation
(AI) Braille: read a lone key signature in a keyboard segment heading - #2087
Merged
mscuthbert merged 1 commit intoOct 19, 2026
Merged
Conversation
Member
|
LGTM -- Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1986: keyboard braille no longer aborts with
AttributeError: 'KeySignature' object has no attribute 'symbol'when a segment opens with a key change and no meter change.BrailleGrandSegment.extractHeadingtestedisinstanceon the grouping rather than its element, so a grouping holding only aKeySignaturewas passed on as the time signature. As you suggested in the issue, the SIGNATURE branch now walks the grouping and takes the firstKeySignatureand the firstTimeSignature, without assuming their order or count.test_keyboardInteriorKeyChangeWithoutMeterChangeinbraille/test.pybuilds an 8-measure keyboard score with aBrailleSegmentDivisionand a change to two sharps at measure 5, and checks the exact braille. It fails at master with the error above and passes with this change.How this was tested
pytest music21/braillepasses (73 tests), andpython -m music21.braille.<module>passes for basic, segment, translate, test, noteGrouping, text, objects and lookup, which also runs their doctests. Windows, Python 3.14 only.I left the
handleArticulationsfingering warning path that the issue also mentions for a separate change.🤖 Generated with Claude Code