Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## staging #1483 +/- ##
===========================================
+ Coverage 10.74% 11.62% +0.87%
===========================================
Files 1132 1134 +2
Lines 113993 114195 +202
===========================================
+ Hits 12254 13272 +1018
+ Misses 101739 100923 -816 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the add-token flow, choosing "Add new Ethereum wallet", creating it and verifying the recovery phrase returns to the wallet picker, which shows a red "Wallet with id ... not found" error from
eth_wallet_radio.dart:37. Going back and pressing Next again works.Cause
Wallet.createwrites the new wallet's info to Isar beforepWallets.addWalletruns at the end of the verify step (verify_recovery_phrase_view.dart:295).SelectWalletForTokenViewbuilds its list frompAllWalletsInfo, so it rebuilt with the new wallet id while that wallet wasn't inpWalletsyet, andEthWalletRadiothrew throughWallets.getWallet.Change
The picker skips wallet ids that aren't registered in
pWalletsyet, and watchesnewEthWalletTriggerTempUntilHiveCompletelyDeleted, which the verify step already toggles right afteraddWallet, so it rebuilds once the wallet is registered.Tested
flutter test: 687 passed, 8 skipped, 0 failed (no existing test covers this view).Not done
select_wallet_for_sol_token_view.darthas the same pattern, but nothing toggles its trigger afteraddWallet, so filtering there alone could hide a new Solana wallet until the next rebuild. It needs the trigger toggled in the verify step as well; left for a follow-up with its own test.