Skip to content

Desktop: fill the address book chooser without visiting the Address Book page first - #1491

Merged
julian-CStack merged 6 commits into
stagingfrom
fix/desktop-address-book-chooser
Nov 3, 2026
Merged

julian-CStack merged 6 commits into
stagingfrom
fix/desktop-address-book-chooser

fix(address book): leave out a Spark wallet whose Spark address fails

eefcf5d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 3, 2026 in 0s

11.63% (+0.01%) compared to a22cfcb

View this Pull Request on Codecov

11.63% (+0.01%) compared to a22cfcb

Details

Codecov Report

❌ Patch coverage is 30.98592% with 49 lines in your changes missing coverage. Please review.
✅ Project coverage is 11.63%. Comparing base (a22cfcb) to head (eefcf5d).
⚠️ Report is 1 commits behind head on staging.

Files with missing lines Patch % Lines
..._address_chooser/address_book_address_chooser.dart 0.00% 33 Missing ⚠️
...ecific/address_book_view/desktop_address_book.dart 0.00% 15 Missing ⚠️
lib/services/address_book_service.dart 95.65% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #1491      +/-   ##
===========================================
+ Coverage    11.62%   11.63%   +0.01%     
===========================================
  Files         1134     1134              
  Lines       114193   114210      +17     
===========================================
+ Hits         13272    13294      +22     
+ Misses      100921   100916       -5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.