Skip to content

fix(plugin-basic-ui): support Core and React 1.x (FEP-3032) - #764

Merged
ENvironmentSet merged 2 commits into
mainfrom
feature/fep-3032
Oct 12, 2026
Merged

ENvironmentSet merged 2 commits into
mainfrom
feature/fep-3032

Conversation

@ENvironmentSet

@ENvironmentSet ENvironmentSet commented Oct 12, 2026 •

Copy link
Copy Markdown
Collaborator

Core/Stackflow React 1.x를 유지한 채 최신 Basic UI의 좌우 SafeArea 대응을 사용할 수 있도록 지원 범위를 확장합니다. React 1.3.2에는 전역 useFlow export가 없어 peer 범위만 변경하면 렌더링이 실패하므로, Basic UI 내부에서 구버전의 useActions도 사용할 수 있게 합니다.

  • Basic UI와 하위 의존성인 React UI Core 모두 Core ^1.1.0-canary.0 || ^2.0.0 || ^3.0.0, Stackflow React ^1.3.2-canary.0 || ^2.0.0을 지원합니다.
  • AppScreen, AppBar, Modal, BottomSheet는 usePop으로 pop을 받습니다. usePop 안에서 useFlow 또는 구버전 useActions를 선택합니다.
  • 두 패키지에 patch Changeset을 추가했습니다. 릴리스 복사본에서 Basic UI 1.19.1이 React UI Core ^1.3.8을 요구하는 것을 확인했습니다.

검증:

  • yarn install --immutable, yarn build, yarn typecheck를 통과했습니다.
  • yarn ultra -r test --watchman=false --runInBand: 기존 테스트 191개를 통과했습니다. 로컬 샌드박스의 Watchman 접근 제한 때문에 Watchman을 비활성화했습니다.
  • 릴리스 형태로 묶은 두 패키지를 아래 다섯 소비자 프로젝트에 설치했습니다. 모두 peer 경고 없이 설치되었으며, 소스와 소비자 타입 검사, CommonJS/ESM SSR, JSDOM에서 Android/Cupertino 렌더링과 AppBar 뒤로가기·Modal/BottomSheet 닫기를 통과했습니다. React 1.x의 /future 진입점도 렌더링과 탐색을 확인했습니다.
Core Stackflow React Config
1.1.0-canary.0 1.3.2-canary.0 1.0.1-canary.0
1.1.0 1.3.2 1.1.0
1.3.2 1.12.0 1.2.2
2.0.0 2.0.0 2.0.0
3.1.0 2.1.4 2.0.0
  • peer 범위만 넓힌 패키지는 React 1.3.2에서 useFlow is not a function으로 실패하고, 호환 훅을 포함한 패키지는 통과하는 것을 재현했습니다. 배포 CSS에 좌우 SafeArea 규칙이 포함된 것도 확인했습니다.
  • 변경한 TS/TSX의 Biome 검사는 오류 없이 통과했습니다. 기존 mounted 미사용 경고 두 개가 있습니다.

Closes FEP-3032.

@changeset-bot

changeset-bot Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: ee677d6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@stackflow/plugin-basic-ui Patch
@stackflow/react-ui-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Repository: daangn/stackflow/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f8bb4564-89b0-48d6-a78f-da790dffe7a8

📥 Commits

Reviewing files that changed from the base of the PR and between 6df3fd8 and ee677d6.


⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock

📒 Files selected for processing (8)
  • .changeset/quiet-spoons-wink.md
  • extensions/plugin-basic-ui/package.json
  • extensions/plugin-basic-ui/src/components/AppBar.tsx
  • extensions/plugin-basic-ui/src/components/AppScreen.tsx
  • extensions/plugin-basic-ui/src/components/BottomSheet.tsx
  • extensions/plugin-basic-ui/src/components/Modal.tsx
  • extensions/plugin-basic-ui/src/usePop.ts
  • extensions/react-ui-core/package.json

 _____________________________
< I wish to make a complaint. >
 -----------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR

🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Deploying stackflow-demo with  Cloudflare Pages  Cloudflare Pages

Latest commit: ee677d6
Status: ✅  Deploy successful!
Preview URL: https://9e138f31.stackflow-demo.pages.dev
Branch Preview URL: https://feature-fep-3032.stackflow-demo.pages.dev

View logs

@pkg-pr-new

pkg-pr-new Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
  • @stackflow/demo

    yarn add https://pkg.pr.new/@stackflow/plugin-basic-ui@764.tgz
    
    yarn add https://pkg.pr.new/@stackflow/react-ui-core@764.tgz
    

commit: ee677d6

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
stackflow-docs ee677d6 Commit Preview URL Oct 12 2026, 02:00 PM

@ENvironmentSet
ENvironmentSet marked this pull request as ready for review October 12, 2026 13:57
@ENvironmentSet
ENvironmentSet merged commit 7d73f21 into main Oct 12, 2026
11 of 12 checks passed
@ENvironmentSet
ENvironmentSet deleted the feature/fep-3032 branch October 12, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant