Repository navigation
fix(plugin-basic-ui): support Core and React 1.x (FEP-3032) - #764
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: ee677d6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (8)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying stackflow-demo with
|
| Latest commit: |
ee677d6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9e138f31.stackflow-demo.pages.dev |
| Branch Preview URL: | https://feature-fep-3032.stackflow-demo.pages.dev |
commit: |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
stackflow-docs | ee677d6 | Commit Preview URL | Oct 12 2026, 02:00 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core/Stackflow React 1.x를 유지한 채 최신 Basic UI의 좌우 SafeArea 대응을 사용할 수 있도록 지원 범위를 확장합니다. React 1.3.2에는 전역
useFlowexport가 없어 peer 범위만 변경하면 렌더링이 실패하므로, Basic UI 내부에서 구버전의useActions도 사용할 수 있게 합니다.^1.1.0-canary.0 || ^2.0.0 || ^3.0.0, Stackflow React^1.3.2-canary.0 || ^2.0.0을 지원합니다.usePop으로pop을 받습니다.usePop안에서useFlow또는 구버전useActions를 선택합니다.^1.3.8을 요구하는 것을 확인했습니다.검증:
yarn install --immutable,yarn build,yarn typecheck를 통과했습니다.yarn ultra -r test --watchman=false --runInBand: 기존 테스트 191개를 통과했습니다. 로컬 샌드박스의 Watchman 접근 제한 때문에 Watchman을 비활성화했습니다./future진입점도 렌더링과 탐색을 확인했습니다.useFlow is not a function으로 실패하고, 호환 훅을 포함한 패키지는 통과하는 것을 재현했습니다. 배포 CSS에 좌우 SafeArea 규칙이 포함된 것도 확인했습니다.mounted미사용 경고 두 개가 있습니다.Closes FEP-3032.