Repository navigation
Fix LightExpression compound assignment round trips without a conversion - #555
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A normal integer compound assignment can compile with
CompileFast, but converting its LightExpression representation back to System.Linq.Expressions throwsNullReferenceException:FromSysExpressionConvertercreates anOpAssignMethodConversionBinaryExpressionthroughMakeBinary. A compound assignment's conversion lambda is optional;CreateSysExpressionunconditionally dereferences it. Preserve an absent conversion when forwarding the arguments to SystemMakeBinary, as the base binary-expression conversion already does.Changes
LightExpressionTests.Run().Validation
1d2a4bd364bd5271f5594074f76e298f5afa53db; both regression methods pass with the fix on .NET 8.0.22 and 10.0.0.FastExpressionCompiler.LightExpression.UnitTestsfor net10.0 passed without warnings/errors.BuildScripts/MakeInternal.ps1completed successfully; generated internal copies are ignored.