Skip to content

Fix in-memory filesystem lookups on Windows #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dkager wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix in-memory filesystem lookups on Windows #855

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/shim_filesystem.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,19 +288,21 @@ cfg_if! {
static IN_MEMORY_DIRS: RwLock<Option<HashSet<String>>> = RwLock::new(None);

pub fn add_in_memory_file(path: &str, content: &str) {
// store the keys the same way they are looked up (get_in_memory_key), so that "/" in 'path'
// still matches on Windows, where the lookup key is built with "\"
let path_obj = Path::new(path);
{
let mut files = IN_MEMORY_FILES.write().unwrap();
files.get_or_insert_with(HashMap::new).insert(path.to_string(), content.to_string());
files.get_or_insert_with(HashMap::new).insert(get_in_memory_key(path_obj), content.to_string());
}

let path_obj = Path::new(path);
{
let mut dirs = IN_MEMORY_DIRS.write().unwrap();
let dirs = dirs.get_or_insert_with(HashSet::new);
for parent in path_obj.ancestors().skip(1) {
let parent_str = parent.to_str().unwrap_or_default();
let parent_str = get_in_memory_key(parent);
if !parent_str.is_empty() {
dirs.insert(parent_str.to_string());
dirs.insert(parent_str);
}
}
}
Expand Down