Repository navigation
More tests for Finnish 6-dot braille and some fixes - #858
Open
samimaattaCelia wants to merge 83 commits into
Open
samimaattaCelia wants to merge 83 commits into
samimaattaCelia wants to merge 83 commits into
Conversation
The test file contained information relating to BANA that is not correct.
When the fraction ends in a parenthesis (dots 356), the dot 6 is used to end the 'dropped dots' zone, so it is not confused with 'dropped dots' for number 0 (dots 356).
In Finnish notation the regular letter is used for denoting the bold letters.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #501
I went through the tests I had made before and compared them with the specification and the Finnish curriculum, so that the tests would cover them well enough.
I also made some fixes to some tests' MathML and the braille output.
If more tests are needed, then I need more information on what kind of tests, since to me these seem to cover pretty well what is expected of the 6-dot braille. It is mainly used for comprehensive school levels of mathematics.