Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Follow-up to #81. Update dnscrypt-proxy from 2.1.5 to 2.1.20 and refresh the publishing workflow dependencies, carrying Dappnode's forwarding extension onto the current upstream implementation.
Approach
forward_fallback_ttl. This allows upstream changes to configuration loading, DNS messages, forwarding, and caching to remain intact.Behavior changes to review: upstream now defaults to Weighted Power of Two resolver selection and enables PQDNSCrypt with compatible resolvers. The rebased extension uses upstream error handling for forwarding rules without a fallback; IP fallbacks now return address records matching the query family. The configured
.ethCNAME fallback remains supported with a default TTL of 600 seconds.Test instructions
docker compose build --pull --no-cache. The build applies the patch and runs the upstream and Dappnode forwarding tests._DAPPNODE_GLOBAL_DOMAINand_DAPPNODE_GLOBAL_INTERNAL_IPvalues on a network with Dappnode's internal DNS aliases..dappnodeforwarding, unknown.ethfallback tomy.dappnode, and domain/PWA cloaking. Check resolver selection and query latency under a representative workload before rollout.Validation: upstream and forwarding tests passed for arm64 and amd64; the image built and its production configuration validated; live external/internal DNS, ENS fallback, and domain/PWA cloaking checks passed with both executables. The amd64 checks ran under emulation. Local image validation used memory-backed compiler scratch space because Docker's disk was full. Publishing workflows were not executed locally.