Repository navigation
Update HTTPS dependencies and fix certificate and proxy handling - #98
Merged
Merged
Conversation
|
Dappnode bot has built and pinned the built packages to an IPFS node, for commit: 676d4dc This is a development version and should only be installed for testing purposes.
Hash: (by dappnodebot/build-action) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The HTTPS package uses end-of-life Node versions and outdated dependencies. RHSB-2026-012 also requires refreshing the trust stores affected by the eMudhra certificate compromise.
Runtime review found that certificate matching compared Promises, scheduled renewals did not reload nginx, proxy targets could insert nginx directives, and thrown reconfiguration errors left failed mappings persisted.
Approach
ca-certificates >=20261020-r0. Refresh both Node's bundled CA store and the system bundle.<6.1). Replace obsoleteejs-lintwith EJS-native template compilation.Review: @dappnode/core
Test instructions
.nvmrcand Yarn Classic 1.22.22, then run:yarn install --frozen-lockfile yarn build yarn lint yarn lint:ejs yarn test yarn auditdocker build --pull --no-cache -t dnp-https:local .Validation completed: ARM64/AMD64 image builds; build, lint, template checks and all 9 regression tests; dependency audit with zero known vulnerabilities; inspection of both CA bundles for the affected roots; live container startup, nginx configuration, redirects and HTTPS forwarding; scheduled renewal serving the replacement certificate after exactly one signing request using local mock services.
Running deployments must be rebuilt and redeployed to receive the trust-store updates.