Repository navigation
fix: use Dappnode DNS and correct CoreDNS port detection - #40
Open
sembrestels wants to merge 1 commit into
Open
sembrestels wants to merge 1 commit into
sembrestels wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
Fix two existing problems in WireGuard's container DNS and CoreDNS startup:
PEERDNS. Without this setting, Docker inherits the host's resolver path, which can return incorrect negative answers. Docker's embedded resolver continues handling service aliases.netstat -lntup). The previousnetstat -apncheck also matched outgoing connections to destination port 53, so ordinary DNS activity could disable CoreDNS on restart even when no local DNS server was listening. ExplicitUSE_COREDNS=falseand detection of a real listener retain their existing behavior.Add a real-socket regression test in disposable containers and update the existing changelog.
How to test
docker build -t wireguard-dns-test . python3 tests/test_coredns_port_detection.py --image wireguard-dns-testThe Python 3.9+ regression test uses a Node helper image (override with
--helper-image). It reproduces the old false positive with a connected UDP socket, verifies that the patched image ignores it, then starts CoreDNS and verifies that a genuine listener is detected. It uses an isolated network namespace and no production VPN data.Validation completed
wg0, and CoreDNS, without publishing host ports or mounting production data.wg0remained active, and the fixture's saved keys/config were unchanged.git diff --check.Other notes for review
This PR is based on current upstream
master(3881f9f) throughsembrestels/DNP_WIREGUARD. It changes DNS configuration and listener detection only; the Dockerfiles, API, runtime versions, VPN profile defaults, and saved Corefile are unchanged. The previously prepared runtime-security updates are separate work.ARM64 and a physical VPN client have not been tested for this branch.