Skip to content

Add test case to tables where join returns none when no values match. #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlonBaker wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add test case to tables where join returns none when no values match. #685

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions tests/test_tables.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1603,6 +1603,13 @@ def test_join_no_rows():
assert t3 == None
t4 = t2.join('letter', t1)
assert t4 == None

def test_join_no_matching_values():
t1 = Table().with_columns('letter', make_array('a', 'b'), 'x', make_array(1, 2))
t2 = Table().with_columns('letter', make_array('c', 'd'), 'y', make_array(3, 4))
assert t1.join('letter', t2) is None
t3 = Table().with_columns('letter', make_array('a', 'b'), 'x', make_array(9, 9))
assert t1.join(['letter', 'x'], t3) is None

def test_percentile(numbers_table):
assert_equal(numbers_table.percentile(76), """
Expand Down