Repository navigation
Pin the vulnerable transitive packages - #54
Merged
Merged
Conversation
Pin SSH.NET (pulled in by Testcontainers.MsSql) and System.Security.Cryptography.Pkcs (pulled in by Microsoft.SqlServer.DacFx) through central package management with transitive pinning, so the Release restore of the test project passes the NuGet audit (NU1902/NU1903). The integration tests in the workflow run in Release again, which makes the audit part of the gate. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01P8xKsmMZRuuoGUZqqpAmVK
With CentralPackageTransitivePinningEnabled, the central Microsoft.NET.Test.Sdk 17.14.1 also pinned the transitive one that MSTest 4.0.2 depends on, which the restore rejected as a downgrade (NU1109). Raise it to 18.0.1, the version MSTest asks for, and regenerate packages.lock.json for the pinned package set. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01P8xKsmMZRuuoGUZqqpAmVK
The Release build of the test project fails on the code analysis rules that Directory.Build.props enables for every project (AnalysisMode AllEnabledByDefault with warnings as errors), which predates the package pins. The tests therefore run in Debug again, and a separate restore with warnings as errors makes the NuGet audit the gate it was meant to be. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01P8xKsmMZRuuoGUZqqpAmVK
RoelantVos
marked this pull request as ready for review
October 26, 2026 18:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Release restore of
Direct_Framework.Integration.Testsfailed the NuGet audit on two transitive packages (seen in the first run of the release pipeline, #53):SSH.NET2024.2.0 throughTestcontainers.MsSql(GHSA-mggc-4xg6-vcxf, GHSA-q939-rpr3-3284) andSystem.Security.Cryptography.Pkcs9.0.9 throughMicrosoft.SqlServer.DacFx(GHSA-2fmv-rv2c-59x7, GHSA-846f-f764-76mx).Directory.Packages.props: enableCentralPackageTransitivePinningEnabledand pinSSH.NET2026.0.0 andSystem.Security.Cryptography.Pkcs10.0.14, the latest stable versions on nuget.org. Transitive pinning also makes the centralMicrosoft.NET.Test.Sdkentry binding for the version MSTest 4.0.2 pulls in, so it moves from 17.14.1 to 18.0.1 (NU1109 otherwise).Direct_Framework.Integration.Tests/packages.lock.jsonregenerated withdotnet restore.Directory.Build.propsturns into errors for every project in Release; that is pre-existing onmainand not touched here.Testing
Direct_Framework.sqlprojbuilds in Release with 0 errors; integration tests under Podman against a freshly built dacpac: 23 of 23 pass.🤖 Generated with Claude Code
https://claude.ai/code/session_01P8xKsmMZRuuoGUZqqpAmVK