Repository navigation
Conversation
…sses Upgrade lib-node 2.15 whose default agents refuse non public addresses. The mails sent through the private directory url use the private client. The web push endpoint is chosen by the user and its response was returned to him: web-push ignores the lib-node agents (not instances of https.Agent), so it gets a plain agent with the public lookup, IP literals are checked before the call. Dev environments allow the loopback with SSRF_PUBLIC_IPS. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Posting a subscription or a webhook subscription with the _id of another user or account replaced it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade lib-node 2.15 / lib-express 1.28.1: the default HTTP client now refuses non public addresses (loopback, private ranges, cloud metadata…).
https.Agentinstances), so it gets a plain agent with lib-node'spublicLookup, and IP literals are checked before the call._idof another user/account replaced it, it is now refused (403 / 404).SSRF_PUBLIC_IPS=127.0.0.1,::1(dev/init-env.sh).Why: SSRF hardening across the data-fair stack, plus a subscription takeover found during the audit.
Heads-up: webhooks targeting private/intranet addresses now fail unless the address is listed in
SSRF_PUBLIC_IPS(check existing subscriptions before deploying). Verify mails, web push and webhooks on staging.