Repository navigation
Update Snowflake JDBC driver to 4.3.4 - #68
Open
vishwasvaidya-cloudsufi wants to merge 1 commit into
Open
vishwasvaidya-cloudsufi wants to merge 1 commit into
vishwasvaidya-cloudsufi wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request upgrades the snowflake-jdbc dependency version from 4.0.2 to 4.3.4 in pom.xml. It also introduces a new unit test, SnowflakeS3StageEndpointTest.java, to verify that the S3 client correctly handles and normalizes schemeless stage endpoints returned by Snowflake (such as those from government accounts). I have no feedback to provide as there are no review comments to evaluate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
snowflake-jdbc.versionfrom4.0.2to4.3.4.Driver 4.0.2 fails to create the S3 client when the stage endpoint has no URI scheme. Snowflake Government accounts return their endpoint this way, so every read (
downloadStream) fails onthose accounts with:
java.lang.NullPointerException: The URI scheme of endpointOverride must not be null.
Snowflake fixed this upstream in snowflakedb/snowflake-jdbc#2572 (SNOW-3344317), first released in 4.2.0. In 4.3.4, an endpoint without a scheme gets
https://added before the client is built.The plugin code needs no changes: the driver APIs it uses (
SnowflakeConnection,UploadStreamConfig,DownloadStreamConfig,SnowflakeBasicDataSource) are the same in 4.3.4.The driver is still built for Java 8, and the CDAP parent range is unchanged, so CDAP 6.10 and 6.11 stay supported.Changes
pom.xml:snowflake-jdbc.version4.0.2 → 4.3.4SnowflakeS3StageEndpointTest: builds the S3 client the same waydownloadStreamdoes (StageInfo→StorageClientFactory.createClient) and checks the endpoint it ends up with:https://<endpoint>https://endpoint → unchangedTesting
SnowflakeS3StageEndpointTest