Add acceptance coverage for BOM notebook deletion badness by janniklasrose · Pull Request #7247 · databricks/cli

janniklasrose · 2026-10-29T10:52:23Z

Changes

Extend the sync replacement acceptance test through deletion and document the orphaned BOM notebook with Badness in test.toml.

Why

After #7218, a BOM-prefixed bom.sql uploads as notebook bom, while sync tracks bom.sql. Removing the local file makes sync report a successful deletion but leaves the remote notebook behind. This test captures the current bug, with plain.sql as a control that is deleted successfully.

Tests

Targeted local acceptance test passes in both DMS modes, using a temporary modfile replacing golang.org/x/net v0.62.0 with cached v0.61.0. Repository dependencies are unchanged.
Formatting, shell syntax, and diff checks pass.
Full checks, lint, and tests could not pass locally: the dependency proxy denies v0.62.0, and full tests also lack Python 3.10/3.13.
Cloud execution was not run; the test retains Cloud = true.

This PR was written by Codex.

github-actions · 2026-10-29T10:58:12Z

Commit: 5ff5a7376 | Workflow run

Regression test report

Selected 1 changed tests (limit=20, 0 not selected)

2 tests: regression=0 unreleased=0 coverage=2 failing=0

test	branch	main (`1437f3c`)	latest (v1.23.0)
TestAccept/bundle/sync/replace-node-type/DMS=	✅	✅	✅
TestAccept/bundle/sync/replace-node-type/DMS=true	✅	✅	✅

eng-dev-ecosystem-bot · 2026-10-29T11:13:38Z

Integration test report

Commit: 5ff5a73

Run: 41484038685

	Env	✅pass	🙈skip	Time
✅	aws linux-2core-8gb	284	15	6:29
✅	aws-windows-latest-4core-16gb	286	13	4:04
✅	azure linux-2core-8gb	283	15	7:48
✅	azure-windows-latest-4core-16gb	285	13	3:52
✅	gcp linux-2core-8gb	284	15	8:15
✅	gcp-windows-latest-4core-16gb	286	13	4:02

Top 3 slowest tests (at least 2 minutes):

duration	env	testname
4:11	gcp linux-2core-8gb	TestAccept
4:10	azure linux-2core-8gb	TestAccept
4:04	aws linux-2core-8gb	TestAccept

Sankalp-Mittal

Approved with a comment

eng-dev-ecosystem-bot · 2026-11-02T21:12:48Z

Integration test report

Commit: c9e71ca

Run: 41489557859

	Env	❌FAIL	🔄flaky	✅pass	🙈skip	Time
❌	aws linux-2core-8gb	2	2	1500	1226	230:18
❌	aws-windows-latest-4core-16gb	2	4	1423	1251	226:20
🔄	azure linux-2core-8gb		10	1341	1278	202:36
🔄	azure-windows-latest-4core-16gb		4	1272	1303	201:32
🔄	gcp linux-2core-8gb		6	1332	1283	216:10
🔄	gcp-windows-latest-4core-16gb		3	1260	1308	222:02

27 interesting tests: 25 flaky, 2 FAIL

	Test Name	aws linux-2core-8gb	aws-windows-latest-4core-16gb	azure linux-2core-8gb	azure-windows-latest-4core-16gb	gcp linux-2core-8gb	gcp-windows-latest-4core-16gb
❌	TestAccept	❌F	❌F	✅p	✅p	✅p	🔄f
🔄	TestAccept/bundle/invariant/delete_idempotent	✅p	✅p	🔄f	✅p	✅p	✅p
🔄	TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=app.yml.tmpl/READPLAN=1	✅p	✅p	🔄f	✅p	✅p	✅p
🔄	TestAccept/bundle/resources/apps/lifecycle-started	✅p	✅p	✅p	✅p	✅p	🔄f
🔄	TestAccept/bundle/resources/apps/lifecycle-started/DMS=true	✅p	✅p	✅p	✅p	✅p	🔄f
🔄	TestAccept/bundle/resources/catalogs/with-schemas	✅p	✅p	✅p	🔄f	✅p	✅p
🔄	TestAccept/bundle/resources/catalogs/with-schemas/DMS=	✅p	✅p	✅p	🔄f	✅p	✅p
🔄	TestAccept/bundle/resources/cluster_policies/permissions/levels	✅p	🔄f	✅p	✅p	✅p	✅p
🔄	TestAccept/bundle/resources/cluster_policies/permissions/levels/DMS=	✅p	🔄f	✅p	✅p	✅p	✅p
🔄	TestAccept/bundle/resources/grants/catalogs	✅p	✅p	🔄f	✅p	✅p	✅p
🔄	TestAccept/bundle/resources/grants/catalogs/DMS=	✅p	✅p	🔄f	✅p	✅p	✅p
🔄	TestAccept/bundle/resources/grants/schemas/remove_principal	✅p	✅p	🔄f	✅p	✅p	✅p
🔄	TestAccept/bundle/resources/grants/schemas/remove_principal/DMS=true	✅p	✅p	🔄f	✅p	✅p	✅p
🔄	TestAccept/bundle/resources/postgres_branches/replace_existing	✅p	🔄f	🙈s	🙈s	🙈s	🙈s
🔄	TestAccept/bundle/resources/postgres_branches/replace_existing/DMS=true	✅p	🔄f
❌	TestAccept/bundle/resources/postgres_projects/factcheck/update_mask_spec	❌F	❌F	🙈s	🙈s	🙈s	🙈s
🔄	TestAccept/bundle/resources/schemas/comment_out_of_band	✅p	✅p	🔄f	🔄f	🔄f	✅p
🔄	TestAccept/bundle/resources/schemas/comment_out_of_band/DMS=	✅p	✅p	🔄f	✅p	✅p	✅p
🔄	TestAccept/bundle/resources/schemas/comment_out_of_band/DMS=true	✅p	✅p	✅p	🔄f	🔄f	✅p
🔄	TestAccept/bundle/resources/vector_search_endpoints/basic	✅p	✅p	✅p	✅p	🔄f	✅p
🔄	TestAccept/bundle/resources/vector_search_endpoints/basic/DMS=	✅p	✅p	✅p	✅p	🔄f	✅p
🔄	TestAccept/bundle/resources/volumes/comment_with_rename	✅p	✅p	✅p	✅p	🔄f	✅p
🔄	TestAccept/bundle/resources/volumes/comment_with_rename/DMS=	✅p	✅p	✅p	✅p	🔄f	✅p
🔄	TestFsCpDir	✅p	✅p	🔄f	✅p	✅p	✅p
🔄	TestFsCpDir/uc-volumes_to_uc-volumes	✅p	✅p	🔄f	✅p	✅p	✅p
🔄	TestFilerRecursiveDelete	🔄f	✅p	✅p	✅p	✅p	✅p
🔄	TestFilerRecursiveDelete/files	🔄f	✅p	✅p	✅p	✅p	✅p

Top 50 slowest tests (at least 2 minutes):

duration	env	testname
14:28	gcp linux-2core-8gb	TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
12:07	gcp linux-2core-8gb	TestAccept/bundle/resources/clusters/lifecycle-started/DMS=true
12:01	gcp linux-2core-8gb	TestAccept/bundle/resources/apps/lifecycle-started/DMS=
10:58	aws linux-2core-8gb	TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
10:18	azure-windows-latest-4core-16gb	TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
10:09	aws-windows-latest-4core-16gb	TestAccept/bundle/resources/apps/lifecycle-started/DMS=
9:57	aws linux-2core-8gb	TestAccept/bundle/resources/apps/lifecycle-started/DMS=
9:57	azure linux-2core-8gb	TestAccept/bundle/resources/apps/lifecycle-started/DMS=
9:30	gcp-windows-latest-4core-16gb	TestAccept/bundle/resources/apps/lifecycle-started/DMS=
9:27	azure-windows-latest-4core-16gb	TestAccept/bundle/resources/apps/lifecycle-started/DMS=
9:11	aws linux-2core-8gb	TestAccept/bundle/resources/clusters/lifecycle-started/DMS=
9:06	aws-windows-latest-4core-16gb	TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
9:04	azure linux-2core-8gb	TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
8:44	gcp linux-2core-8gb	TestAccept/bundle/resources/clusters/lifecycle-started/DMS=
8:44	gcp-windows-latest-4core-16gb	TestAccept/bundle/resources/clusters/deploy/local_ssd_count/DMS=true
8:42	aws linux-2core-8gb	TestAccept/bundle/invariant/no_drift/DMS=true/INPUT_CONFIG=cluster_libraries.yml.tmpl/READPLAN=
8:17	aws-windows-latest-4core-16gb	TestAccept/bundle/resources/clusters/lifecycle-started/DMS=
8:05	aws linux-2core-8gb	TestAccept/bundle/invariant/no_drift/DMS=true/INPUT_CONFIG=cluster_apply_policy_default_values.yml.tmpl/READPLAN=
7:51	gcp-windows-latest-4core-16gb	TestAccept/bundle/resources/clusters/lifecycle-started/DMS=
7:50	gcp-windows-latest-4core-16gb	TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
7:47	gcp-windows-latest-4core-16gb	TestAccept/bundle/resources/clusters/lifecycle-started/DMS=true
7:45	aws linux-2core-8gb	TestAccept/bundle/resources/clusters/lifecycle-started/DMS=true
7:41	gcp-windows-latest-4core-16gb	TestAccept/bundle/resources/clusters/deploy/local_ssd_count/DMS=
7:39	gcp linux-2core-8gb	TestAccept/bundle/resources/clusters/deploy/local_ssd_count/DMS=
7:38	aws linux-2core-8gb	TestAccept/bundle/invariant/no_drift/DMS=true/INPUT_CONFIG=cluster.yml.tmpl/READPLAN=1
7:30	aws-windows-latest-4core-16gb	TestAccept/bundle/invariant/no_drift/DMS=true/INPUT_CONFIG=cluster_libraries.yml.tmpl/READPLAN=
7:17	aws linux-2core-8gb	TestAccept/bundle/invariant/no_drift/DMS=true/INPUT_CONFIG=cluster.yml.tmpl/READPLAN=
7:17	gcp linux-2core-8gb	TestAccept/bundle/resources/clusters/deploy/local_ssd_count/DMS=true
7:12	aws-windows-latest-4core-16gb	TestAccept/bundle/invariant/no_drift/DMS=true/INPUT_CONFIG=cluster.yml.tmpl/READPLAN=1
7:00	aws-windows-latest-4core-16gb	TestAccept/bundle/resources/clusters/lifecycle-started/DMS=true
6:52	aws-windows-latest-4core-16gb	TestAccept/bundle/resources/clusters/lifecycle-started-toggle/DMS=true
6:41	aws linux-2core-8gb	TestAccept/bundle/config-remote-sync/multiple_resources/DMS=
6:41	aws-windows-latest-4core-16gb	TestAccept/bundle/invariant/no_drift/DMS=true/INPUT_CONFIG=cluster_apply_policy_default_values.yml.tmpl/READPLAN=
6:39	aws linux-2core-8gb	TestAccept/bundle/config-remote-sync/multiple_resources/DMS=true
6:36	azure-windows-latest-4core-16gb	TestAccept/bundle/resources/clusters/lifecycle-started/DMS=true
6:29	gcp linux-2core-8gb	TestAccept/bundle/resources/clusters/lifecycle-started-toggle/DMS=true
6:28	gcp linux-2core-8gb	TestAccept/bundle/resources/apps/lifecycle-started-omitted/DMS=true
6:21	gcp linux-2core-8gb	TestAccept/bundle/config-remote-sync/multiple_resources/DMS=true
6:18	azure linux-2core-8gb	TestAccept/bundle/config-remote-sync/multiple_resources/DMS=
6:13	azure linux-2core-8gb	TestAccept/bundle/resources/clusters/lifecycle-started/DMS=true
6:11	aws-windows-latest-4core-16gb	TestAccept/bundle/invariant/no_drift/DMS=true/INPUT_CONFIG=cluster_libraries.yml.tmpl/READPLAN=1
6:08	gcp linux-2core-8gb	TestAccept/bundle/config-remote-sync/multiple_resources/DMS=
5:58	azure linux-2core-8gb	TestAccept/bundle/resources/clusters/lifecycle-started/DMS=
5:57	azure-windows-latest-4core-16gb	TestAccept/bundle/resources/clusters/lifecycle-started/DMS=
5:51	gcp-windows-latest-4core-16gb	TestAccept/bundle/resources/apps/lifecycle-started-omitted/DMS=
5:41	gcp-windows-latest-4core-16gb	TestAccept/bundle/resources/apps/lifecycle-started-omitted/DMS=true
5:41	azure-windows-latest-4core-16gb	TestAccept/bundle/resources/clusters/lifecycle-started-toggle/DMS=true
5:39	aws-windows-latest-4core-16gb	TestAccept/bundle/invariant/no_drift/DMS=true/INPUT_CONFIG=cluster.yml.tmpl/READPLAN=
5:38	gcp linux-2core-8gb	TestAccept/bundle/resources/clusters/lifecycle-started-toggle/DMS=
5:35	aws-windows-latest-4core-16gb	TestAccept/bundle/invariant/no_drift/DMS=true/INPUT_CONFIG=cluster_apply_policy_default_values.yml.tmpl/READPLAN=1

Test sync deletion of BOM-prefixed notebooks

5197a23

github-actions Bot added the DABs DABs related issues label Oct 29, 2026

janniklasrose requested review from Sankalp-Mittal and shreyas-goenka October 29, 2026 11:42

janniklasrose marked this pull request as ready for review October 29, 2026 11:42

janniklasrose requested review from a team as code owners October 29, 2026 11:42

Sankalp-Mittal reviewed Nov 2, 2026

View reviewed changes

Comment thread acceptance/bundle/sync/replace-node-type/test.toml Resolved

Sankalp-Mittal approved these changes Nov 2, 2026

View reviewed changes

Sankalp-Mittal mentioned this pull request Nov 2, 2026

Detect notebooks with the workspace's first-line rule #7290

Open

Apply suggestion from @Sankalp-Mittal

5ff5a73

janniklasrose enabled auto-merge November 2, 2026 16:44

janniklasrose added this pull request to the merge queue Nov 2, 2026

Merged via the queue into main with commit c9e71ca Nov 2, 2026
27 checks passed

janniklasrose deleted the janniklasrose/test-sync-bom-delete branch November 2, 2026 17:14

Navigation Menu

Repository navigation

Add acceptance coverage for BOM notebook deletion badness - #7247

Add acceptance coverage for BOM notebook deletion badness#7247
janniklasrose merged 2 commits into
mainfrom
janniklasrose/test-sync-bom-delete

janniklasrose commented Oct 29, 2026

Uh oh!

github-actions Bot commented Oct 29, 2026 •

edited

Loading

Uh oh!

eng-dev-ecosystem-bot commented Oct 29, 2026 •

edited

Loading

Uh oh!

Uh oh!

Sankalp-Mittal left a comment

Uh oh!

Uh oh!

eng-dev-ecosystem-bot commented Nov 2, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

janniklasrose commented Oct 29, 2026

Changes

Why

Tests

Uh oh!

github-actions Bot commented Oct 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression test report

Uh oh!

eng-dev-ecosystem-bot commented Oct 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Integration test report

Uh oh!

Uh oh!

Sankalp-Mittal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

eng-dev-ecosystem-bot commented Nov 2, 2026

Integration test report

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Oct 29, 2026 •

edited

Loading

eng-dev-ecosystem-bot commented Oct 29, 2026 •

edited

Loading