Repository navigation
Conversation
Collaborator
Integration test reportCommit: 8908e98
Top 3 slowest tests (at least 2 minutes):
|
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
denik
force-pushed
the
denik/locker-unlock-error
branch
from
November 2, 2026 11:18
c7cb288 to
121a882
Compare
Co-authored-by: Isaac <no-reply@databricks.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Locker.Unlockre-reads the lock file to check that it still holds the lock. Only a missing lock file or one held by someone else is now reported asunlock called when lock is not held; any other read error becomesfailed to check the deploy lock before releasing it: <err>.Why
A read that timed out produced a misleading message (CI dashboard,
bundle/invariant/delete_idempotenton Azure):The lock was held; we just failed to read it.
Dashboard: test acceptance.TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=feature.yml.tmpl/READPLAN=; error 3019.
Tests
New unit tests in
libs/lockerfor both cases; existingbundle/deploy/lockacceptance tests pass.This pull request and its description were written by Isaac.