Skip to content

Generate the modular Go SDK's field mapping in climod with genkit's cli-mod mode #7268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
parthban-db wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Generate the modular Go SDK's field mapping in climod with genkit's cli-mod mode #7268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions Taskfile.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -858,10 +858,16 @@ tasks:
# version bumps (go.mod/go.sum) are a manual `go get` step beforehand;
# TestConsistentDatabricksSdkVersion asserts the two stay in sync.
#
# The same run refreshes climod/.codegen/ in genkit's cli-mod mode:
# sdk-go-field-paths.txt maps each field of the modular Go SDK
# (github.com/databricks/sdk-go) to its JSON path, and cli.json holds the same
# mapping per message. That SDK's names differ from the classic SDK's, so the
# files come from its own proto view rather than from the OpenAPI spec.
#
# No `sources:`/`generates:`: this task deliberately refreshes cli.json from
# an external Universe checkout whenever it is invoked.
generate-clijson:
desc: Produce .codegen/cli.json from its pinned Universe commit via genkit
desc: Produce .codegen/cli.json and climod/.codegen/ from their pinned Universe commit via genkit
vars:
UNIVERSE_DIR:
sh: echo "${UNIVERSE_DIR:-$HOME/universe}"
Expand Down Expand Up @@ -898,15 +904,21 @@ tasks:
fi
git -C "$BUILD_DIR/universe" checkout --quiet --detach "$OPENAPI_SHA"

echo "Building genkit and OpenAPI spec at ${OPENAPI_SHA}..."
echo "Building genkit, OpenAPI spec, and Go SDK descriptor set at ${OPENAPI_SHA}..."
cd "$BUILD_DIR/universe"
./tools/bazel build //deco/genkit //openapi:all-internal.json
./tools/bazel build //deco/genkit //openapi:all-internal.json \
//deco/public_proto:public_proto_sdk_go_descriptor_set_with_source_info

echo "Generating CLI code..."
"$BUILD_DIR/universe/bazel-bin/deco/genkit/genkit_/genkit" update-sdk \
--dir "{{.ROOT_DIR}}" \
--openapi-spec-file "$BUILD_DIR/universe/bazel-bin/openapi/all-internal.json" \
--openapi-spec-sha "$OPENAPI_SHA"

echo "Generating the modular Go SDK's CLI spec..."
"$BUILD_DIR/universe/bazel-bin/deco/genkit/genkit_/genkit" experimental-update-sdk \
--dir "{{.ROOT_DIR}}/climod" \
--descriptor-set "$BUILD_DIR/universe/bazel-bin/deco/public_proto/public_proto_sdk_go_with_source_info.pb"
# The SDK-version consistency check runs here for fast feedback when
# generate-clijson is invoked manually. Cleanup of genkit's output is
# delegated to generate-clijson-post so the SDK bumper can reuse it.
Expand Down
3 changes: 3 additions & 0 deletions climod/.codegen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"mode": "cli-mod"
}
1 change: 1 addition & 0 deletions climod/.codegen/.gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
cli.json linguist-generated=true
Loading
Loading