Repository navigation
Make sure variable-based paths get /Workspace or /Volume prefixes - #7286
Open
lennartkats-db wants to merge 1 commit into
Open
lennartkats-db wants to merge 1 commit into
lennartkats-db wants to merge 1 commit into
Conversation
Contributor
|
Commit: Regression test reportSelected 1 changed tests (limit=20, 0 not selected) 2 tests: regression=2 unreleased=0 coverage=0 failing=0
TestAccept/bundle/variables/prepend-workspace-var/DMS=: branch ✅ | main (3aa5c96) ❌ | latest (v1.23.0) ❌main (3aa5c96): latest (v1.23.0): same output as main (3aa5c96) TestAccept/bundle/variables/prepend-workspace-var/DMS=true: branch ✅ | main (3aa5c96) ❌ | latest (v1.23.0) ❌main (3aa5c96): latest (v1.23.0): same output as main (3aa5c96) |
Collaborator
Integration test reportCommit: c6a2a95
Top 3 slowest tests (at least 2 minutes):
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue #2181 reports that
bundle validateleaves a job file path under/Userswhenworkspace.root_pathbegins with a variable. Prefixing currently runs before non-resource variable resolution, so the variable-led path is skipped.Run workspace path prefixing again after variable resolution. Preserve exact
/Workspaceand/Volumesroots in the prefix mutator.Before and after
/Usersfor dev and/Sharedfor prod without the/Workspaceprefix./Usersor/Shared,bundle validateemits one/Workspaceprefix on derived workspace paths and the job file path.Verification
c6a2a950b545d7d15227cad65cdcba72c427efd9.prepend-workspace-varacceptance fixture passed its dev and prod variants.