Repository navigation
[draft] Fix bundle/config/mutator/resourcemutator/apply_presets.go - #7287
Open
lennartkats-db wants to merge 2 commits into
Open
lennartkats-db wants to merge 2 commits into
lennartkats-db wants to merge 2 commits into
Conversation
Collaborator
Integration test reportCommit: f04aa2d
Top 3 slowest tests (at least 2 minutes):
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve literal trailing and repeated underscores from a custom
presets.name_prefixwhen naming bundle schemas. Keep the prefix generated by development mode on its existing normalization path.Before
Issue #2305 reports that a schema named
qcinmy_catalogbecomesmy_catalog.my_userqcwhen the custom prefix resolves tomy_user_. The issue expectsmy_catalog.my_user_qcand also reports that repeated underscores are collapsed.After
ApplyPresetsnow preserves the literal underscores in custom schema prefixes while normalizing the other prefix segments. For the reported example, the schema name ismy_user_qc. The change is limited to schema names; the generated development prefix retains its existing behavior.Verification
TestApplyPresetsSchemaPrefixPreservesUnderscores, failed at base3aa5c9607bff73d3fb18a4c6e63b9f03235f3de7and passed at head6692d77a3f251a4c32024aa3007d41a5ebf1e6a3. The cases cover trailing and repeated underscores, a bracketed custom prefix, and the generated development prefix.databricks bundle deploywas not exercised in the saved test receipt. Current-head CI remains a publication gate.Review notes
Existing deployments using a custom prefix with literal underscores may receive a different schema name after this change. The host records the independent output review as skipped under the pilot policy; this is not an independent approval.