Repository navigation
Conversation
Contributor
|
Before you submit for review:
If you did not complete any of these, then please explain below. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional Linux direct-I/O reader for immutable on-disk indexes. The mapped reader remains the default.
Usage
Requires JDK 22+ with the native module, native access enabled, and supported little-endian Linux x86_64 or AArch64 storage. ioDepth=0 selects synchronous reads; 1–32 selects batched kernel AIO. A nonzero third argument enables a bounded shared block cache. Unsupported configurations fail explicitly.
See the reader documentation for memory budgets and immutable-file/lifetime requirements.
Validation
On Linux x86_64, JDK 23: 39 focused tests pass, covering actual O_DIRECT descriptor flags, primitive and bulk read parity, sector crossings and EOF, concurrent views/cache eviction, pathname replacement, uncached metadata and speculative-read admission, V2–V6/all stored features, DOT_PRODUCT/L2/COSINE search parity, filters and resume. The 14 existing OnDiskGraphIndex tests also passed.
Performance and larger-than-memory benchmark validation are pending. This draft makes no throughput or variability improvement claim. Allocation fixes remain in #755, separate from this storage change.