Repository navigation
Conversation
ecv
approved these changes
Oct 15, 2026
2 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A workload published with
--http-portis always reached over HTTP/1.1, so a gRPC server behind a compute URL can't be called. This adds--http2tocompute deploy, which marks the URL's backend port as HTTP/2 (h2c) through the NetworkServiceappProtocolfield added in datum-cloud/network-services-operator#653.Like
--http-port, the setting carries forward: later deploys keep it until--http2=false, reading it back from the URL because the workload spec has no field for it. If that read fails, the deploy stops instead of quietly switching to HTTP/1.1. The plan summary andworkloads describeboth show when a port is HTTP/2, and--http2is refused with--no-http, with-f, or on a workload with no HTTP port.Test plan
appProtocol, switching on and off across redeploys, and thedescribelineFixes #490