Repository navigation
[pre-commit.ci] pre-commit autoupdate - #5955
pre-commit-ci[bot] wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5955 +/- ##
==========================================
- Coverage 78.26% 77.20% -1.07%
==========================================
Files 1176 1175 -1
Lines 142590 142375 -215
Branches 5072 5079 +7
==========================================
- Hits 111603 109921 -1682
- Misses 29048 30543 +1495
+ Partials 1939 1911 -28 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
njzjz-bot
left a comment
There was a problem hiding this comment.
Ruff 0.16.1 is a compatible patch update: the upstream mirror keeps the same hook IDs and entry points, Python 3.10+ remains supported, and both the release notes and the green CI show no formatter, CLI, or configuration regression. The inline note records the compatibility checks.\n\nCodex quota is about to reset, so I am using the remaining token budget to complete a concentrated review pass over the outstanding PRs.\n\nCoding agent: Codex\nCodex version: codex-cli 0.144.6\nModel: gpt-5.6-sol\nReasoning effort: xhigh
| - repo: https://github.com/astral-sh/ruff-pre-commit | ||
| # Ruff version. | ||
| rev: v0.16.0 | ||
| rev: v0.16.1 |
There was a problem hiding this comment.
Verified against the upstream 0.16.1 release and mirror metadata: the hook IDs and entry points are unchanged, Python 3.10+ remains supported, and this patch release contains bug/fix-safety corrections rather than a CLI or formatter breaking change. Ruff 0.16.0 and 0.16.1 both leave this tree clean, and the PR's required CI is green. No change requested here.
9060af3 to
29b9f0d
Compare
11a1340 to
192e195
Compare
7bd8c1f to
409c2e6
Compare
njzjz-bot
left a comment
There was a problem hiding this comment.
The diff is limited to pre-commit hook revisions (isort 9.0.1, Ruff 0.16.6, clang-format 23.1.0, pylint 4.0.8) with no project-code changes. I did not find a configuration/interface regression in the hook definitions. The PR is currently not mergeable against master and will need an autoupdate/rebase before merging, but the update itself is fine.
Agent: ChatGPT
Model: GPT-5.6 Sol
njzjz-bot
left a comment
There was a problem hiding this comment.
Re-reviewed the current head after the automated hook versions advanced again. The complete diff is limited to .pre-commit-config.yaml: isort 9.0.0b1→9.0.1, Ruff 0.16.0→0.16.6, clang-format 22.1.8→23.1.0, and pylint 4.0.6→4.0.8. All current build/test workflows pass, including C++, C library, Python, CUDA, CodeQL, and packaging. No blocking compatibility issue is apparent in this configuration-only update.
Agent: ChatGPT
Model: GPT-5.6 Sol
GitHub account: njzjz-bot
Reviewed head: 409c2e6
Trigger: scheduled all-PR monitoring
409c2e6 to
0116114
Compare
njzjz-bot
left a comment
There was a problem hiding this comment.
Re-reviewed the new pre-commit.ci head. The complete diff is limited to hook revisions in .pre-commit-config.yaml (isort 9.0.1, Ruff 0.16.7, clang-format 23.1.1, shfmt 3.14.1-1, pylint 4.0.8); I found no concrete compatibility or configuration blocker, and CUDA/build/packaging/CodeQL checks currently pass. I am not approving this head yet because the relevant Test C++ and Test Python workflows are still in progress. No additional inline issue is warranted at this point.
Agent: ChatGPT
Model: GPT-5.6 Sol
GitHub account: njzjz-bot
Reviewed head: 0116114
Trigger: scheduled all-PR monitoring
njzjz-bot
left a comment
There was a problem hiding this comment.
The two checks that were still running on the previous pass (Test C++ and Test Python) have now completed successfully. All pull-request workflow runs for this head are green, including CUDA, C++/C library builds, Python, CodeQL, and packaging. Since the diff is still limited to the reviewed pre-commit hook revisions, no blocker remains.
Agent: ChatGPT
Model: GPT-5.6 Sol
GitHub account: njzjz-bot
Reviewed head: 0116114
Trigger: scheduled all-PR monitoring
0116114 to
9d6ce72
Compare
njzjz-bot
left a comment
There was a problem hiding this comment.
NEEDS HUMAN REVIEW / waiting for exact-head CI completion.
Re-reviewed the newly updated pre-commit head. The complete diff is confined to .pre-commit-config.yaml and advances isort 9.0.0b1→9.0.1, Ruff 0.16.0→0.16.8, clang-format 22.1.8→23.1.1, shfmt 3.13.1-1→3.14.1-1, and pylint 4.0.6→4.0.8. I found no high-confidence compatibility or correctness blocker in the hook configuration itself. Exact-head Test CUDA and Build C++ are green, but Test Python, Test C++, Build C library, CodeQL, and the package/PyPI workflow are still in progress, so approval would be premature under the repository's validation requirements.
Agent: ChatGPT
Model: GPT-5.6 Sol
GitHub account: njzjz-bot
Reviewed head: 9d6ce72
Trigger: scheduled all-PR monitoring
njzjz-bot
left a comment
There was a problem hiding this comment.
Exact-head validation is now complete. Test Python, Test C++, Test CUDA, Build C++, Build C library, CodeQL, and Build and upload to PyPI all completed successfully on 9d6ce72693bc93a4a06a45e3590494db95765500. The complete change remains limited to the previously reviewed pre-commit hook revisions (isort 9.0.1, Ruff 0.16.8, clang-format 23.1.1, shfmt 3.14.1-1, and pylint 4.0.8), with no project-code changes and no remaining high-confidence blocker.
Agent: ChatGPT
Model: GPT-5.6 Sol
GitHub account: njzjz-bot
Reviewed head: 9d6ce72
Trigger: scheduled all-PR monitoring
9d6ce72 to
65d061d
Compare
njzjz-bot
left a comment
There was a problem hiding this comment.
NEEDS HUMAN REVIEW: the current head remains a pre-commit-only update and the exact-head Python, C++, CUDA, build, CodeQL, package/PyPI, and pre-commit checks are green. However, the Read the Docs status is still failing on this head, and I do not have evidence that the docs failure is unrelated to the update. Holding approval until that check is resolved or explicitly waived.
Agent: ChatGPT
Model: GPT-5.6 Sol
GitHub account: njzjz-bot
Reviewed head: 65d061d
Trigger: scheduled all-PR monitoring
65d061d to
fd7c406
Compare
njzjz-bot
left a comment
There was a problem hiding this comment.
Reviewed the new hook revisions relative to the previously reviewed 65d061d and checked the current one-file PR diff. The changes remain confined to pre-commit tool revisions; hook IDs, arguments, file selection and exclusions are unchanged. Exact-head pre-commit succeeds. No new actionable source finding in this delta.
The failed C++ job is attributable to the dependency regression tracked by #6047 rather than a formatter failure: it installed nvalchemi-toolkit-ops==0.4.1 and warp-lang==1.18.0, and the 15 LAMMPS setup exceptions show json.loads receiving a string beginning with "Warp 1.18.0 initialized:" (267 passed, 18 skipped, 15 errors). See https://github.com/deepmodeling/deepmd-kit/actions/runs/37384380279/job/112013920572. The corresponding CPU C++ job on #6047 installs Warp 1.17.0 and succeeds. No dependency changes were made as part of this review.
Python, C++/C-library/package build and CodeQL workflows succeed; the CUDA workflow summary is successful but that alone does not establish GPU execution. Read the Docs remains failed (https://app.readthedocs.org/projects/deepmd/builds/34956699/). Verification was source and upstream log inspection; no local hook/test run was performed.
Agent: dot
Reviewed head: fd7c406
Previous reviewed head: 65d061d
fd7c406 to
a07fd37
Compare
a07fd37 to
7a81206
Compare
| from deepmd.pt_expt.utils import ( # noqa: F401 | ||
| network, | ||
| ) |
| from deepmd.pt_expt.utils import ( # noqa: F401 | ||
| network, | ||
| ) |
njzjz-bot
left a comment
There was a problem hiding this comment.
Agent: dot
Reviewed head: 36412e6
The remaining pre-commit failure is actionable: Ruff reports RUF071 at source/install/build_tf.py:167, where the archive containment check uses os.path.commonprefix(). The exact-head pre-commit log shows isort and every other hook passing; Ruff alone fails, and its suggested correction is classified unsafe, so the configured --fix cannot apply it. This same failure was already present on a07fd37; it is not a new runtime defect introduced by today's import formatting.
I extracted the existing containment function and checked five path cases. Both a sibling path with a shared textual prefix (/tmp/pkg-other/file under /tmp/pkg) and its ../pkg-other/file spelling are incorrectly accepted; the component-aware commonpath control rejects both. Please address this check deliberately, with containment regression coverage, before treating the updated hook suite as qualified. Current log: https://results.pre-commit.ci/run/github/114006193/1792445655.-_Pp-KErRgmzpqs_Xy1LWA
The 14 Python autofix files parse and have equal ASTs after normalizing adjacent imports from the same module; imported names, aliases and registration imports remain present. This is a bounded source check, not backend execution. No additional source regression found. Read the Docs now succeeds. Python/C++ CI is still running; both actual CUDA test jobs are skipped. No approval yet.
updates: - [github.com/PyCQA/isort: 9.0.0b1 → 10.0.0b1](PyCQA/isort@9.0.0b1...10.0.0b1) - [github.com/astral-sh/ruff-pre-commit: v0.16.0 → v0.17.2](astral-sh/ruff-pre-commit@v0.16.0...v0.17.2) - [github.com/pre-commit/mirrors-clang-format: v22.1.8 → v23.1.3](pre-commit/mirrors-clang-format@v22.1.8...v23.1.3) - [github.com/scop/pre-commit-shfmt: v3.13.1-1 → v3.14.1-1](scop/pre-commit-shfmt@v3.13.1-1...v3.14.1-1) - https://github.com/pylint-dev/pylint/: v4.0.6 → v4.1.3
36412e6 to
d0a5beb
Compare
for more information, see https://pre-commit.ci
| system_probabilities, | ||
| uniform_sampling_weights, | ||
| ) | ||
| from deepmd.utils.data_sampling import prob_sys_size_ext as prob_sys_size_ext |
| uniform_sampling_weights, | ||
| ) | ||
| from deepmd.utils.data_sampling import prob_sys_size_ext as prob_sys_size_ext | ||
| from deepmd.utils.data_sampling import process_sys_probs as process_sys_probs |
| system_probabilities, | ||
| uniform_sampling_weights, | ||
| ) | ||
| from deepmd.utils.data_sampling import prob_sys_size_ext as prob_sys_size_ext |
| uniform_sampling_weights, | ||
| ) | ||
| from deepmd.utils.data_sampling import prob_sys_size_ext as prob_sys_size_ext | ||
| from deepmd.utils.data_sampling import process_sys_probs as process_sys_probs |
updates: