Skip to content

suunto_nautic: Jef's Oct 22 review round #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
latishab wants to merge 6 commits into
base: main
Choose a base branch
from
Open

suunto_nautic: Jef's Oct 22 review round #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cf93c75
suunto_nautic: fail a dive when its summary can't be fetched
latishab Oct 19, 2026
28146da
suunto_nautic: report truncated downloads and release errors
latishab Oct 23, 2026
0681954
suunto_nautic: keep the dive list as its raw records
latishab Oct 23, 2026
fb245cb
suunto_nautic: drop the release of a stale handle slot
latishab Oct 23, 2026
49687c5
suunto_nautic: tighten the stream and list checks, document the layouts
latishab Oct 23, 2026
5b97bee
suunto_nautic: return a by-id download's listing error when the link …
latishab Oct 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions include/libdivecomputer/suunto_nautic.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,11 +116,11 @@ suunto_nautic_device_download_summary (dc_device_t *device, const char *logbook_
* id as it appears in a "/Logbook/byId/<id>/..." path (e.g.
* "1787752091"). On success, `raw` holds the decoded SBEM0103 TLV
* stream (magic-verified), suitable for suunto_nautic_parser_create(),
* with the /Summary SBEM appended when it could be fetched.
* with the /Summary SBEM appended.
*
* The download is checked against the size /Logbook/Entries lists for the
* id. On a mismatch it returns DC_STATUS_DATAFORMAT with the (likely
* truncated) dive still in `raw`; on any other failure `raw` is empty.
* id. A download that doesn't match it, like any other failure, returns an
* error with `raw` empty.
*/
dc_status_t
suunto_nautic_device_download (dc_device_t *device, const char *logbook_id, dc_buffer_t *raw);
Expand Down
Loading
Loading