Skip to content

chore(deps): update controller-runtime to v0.25.2 - #1706

Open
rohanKanojia wants to merge 3 commits into
devfile:mainfrom
rohankanojia-forks:pr/chore-update-controller-runtime
Open

rohanKanojia wants to merge 3 commits into
devfile:mainfrom
rohankanojia-forks:pr/chore-update-controller-runtime

Conversation

@rohanKanojia

@rohanKanojia rohanKanojia commented Sep 16, 2026 •

Copy link
Copy Markdown
Member

What does this PR do?

Updates controller-runtime from v0.24.1 to v0.25.2 and the required Kubernetes dependencies to v0.37.0, based on the latest main branch.
Regenerates CRD, deployment, and OLM bundle manifests in a separate commit.

What issues does this PR fix or reference?

None.

Is it tested? How?

  • make generate_all completed successfully.
  • make test DOCKER=not-available passed, including unit tests, controller specs, formatting, and vet checks.

PR Checklist

  • E2E tests pass
    • v8-devworkspace-operator-e2e
    • v8-che-happy-path

Assisted-by: Codex
Signed-off-by: Rohan Kumar rohaan@redhat.com

Summary by CodeRabbit

  • New Features
    • Kubernetes resource schemas now include probe connection settings, volume mount options, volume ownership fields, and emptyDir permission settings.
  • Documentation
    • Clarified ConfigMap environment-variable key behavior and updated descriptions for mount paths, SELinux policies, and volume data sources.
  • Chores
    • Updated Kubernetes and related dependencies.
    • Updated coverage reporting in pull request and code coverage workflows.

@openshift-ci

openshift-ci Bot commented Sep 16, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai

coderabbitai Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: adf96a1e-087a-400e-9d07-75bcbc41503d
📥 Commits

Reviewing files that changed from the base of the PR and between ab8333f and c08669b.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • .github/workflows/code-coverage.yml
  • .github/workflows/pr.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The pull request updates generated Kubernetes and OpenShift CRD schemas with newer probe and volume fields. It revises schema descriptions, upgrades Go dependencies, updates Codecov workflow steps, and removes a leading YAML document separator.

Changes

Kubernetes schema refresh

Layer / File(s) Summary
Operator configuration schemas
deploy/templates/crd/bases/*devworkspaceoperatorconfigs*, deploy/deployment/*/objects/*devworkspaceoperatorconfigs*, deploy/bundle/manifests/*devworkspaceoperatorconfigs*
HTTP probes gain protocol; gRPC probes gain mode; volume mounts gain bindMountOptions. ConfigMap key and SELinux policy descriptions are revised.
Routing and volume schemas
deploy/templates/crd/bases/*devworkspaceroutings*, deploy/deployment/*/objects/*devworkspaceroutings*, deploy/bundle/manifests/*devworkspaceroutings*
Routing schemas gain probe and mount fields, volume owner UID fields, and emptyDir.mode. ConfigMap key and data-source descriptions are revised.
Combined deployment schemas
deploy/deployment/kubernetes/combined.yaml, deploy/deployment/openshift/combined.yaml
Combined manifests include probe and volume schema fields and the related description updates.

Dependency and workflow updates

Layer / File(s) Summary
Dependency and coverage reporting updates
go.mod, .github/workflows/code-coverage.yml, .github/workflows/pr.yml, deploy/templates/components/csv/clusterserviceversion.yaml
Go dependencies and Codecov actions are updated. The CSV manifest loses its leading YAML document separator.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to c0866

No actionable merge-blocking issue is established. The Codecov action upgrade uses the intended release; coverage upload authentication remains to be confirmed through normal workflow checks.

Architecture Summary

Architecture risk: 🔵 Low · up to c0866

The change affects 2 systems.

Changed systems: deploy, go.mod

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — deploy (service) was modified; 11 changed files map to changed impact.
  • observed — go.mod (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in deploy/bundle/manifests/controller.devfile.io_devworkspaceroutings.yaml: The container env configMapKeyRef.key description is expanded to state the key is selected from the ConfigMap's Data field and that BinaryData keys are not propagated.
  • observed — Modified behavior in deploy/bundle/manifests/controller.devfile.io_devworkspaceroutings.yaml: Adds the protocol schema field (nil defaults to HTTP/1.1) to httpGet in the containers' lifecycle postStart handler.
  • observed — Modified behavior in deploy/bundle/manifests/controller.devfile.io_devworkspaceroutings.yaml: Adds the protocol schema field (nil defaults to HTTP/1.1) to httpGet in the containers' lifecycle preStop handler.
  • observed — Modified behavior in deploy/bundle/manifests/controller.devfile.io_devworkspaceroutings.yaml: Adds the mode schema field to the containers' livenessProbe.grpc, documenting TLS vs. Plaintext connection modes with a plaintext default.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: updating controller-runtime to v0.25.2. The dependency-update prefix is concise and relevant.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rohanKanojia rohanKanojia self-assigned this Sep 16, 2026
@rohanKanojia rohanKanojia moved this from Blocked to 🚧 In Progress in Eclipse Che Team B Backlog Sep 16, 2026
@rohanKanojia
rohanKanojia force-pushed the pr/chore-update-controller-runtime branch 2 times, most recently from 1d2fbc7 to 2987934 Compare September 17, 2026 05:24
@openshift-ci

openshift-ci Bot commented Sep 17, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rohanKanojia
Once this PR has been reviewed and has the lgtm label, please assign dkwon17 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rohanKanojia
rohanKanojia marked this pull request as ready for review September 17, 2026 05:31
@rohanKanojia rohanKanojia moved this from 🚧 In Progress to Ready for Review in Eclipse Che Team B Backlog Sep 17, 2026
Assisted-by: Codex
Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@rohanKanojia
rohanKanojia force-pushed the pr/chore-update-controller-runtime branch from 2987934 to 0e5da26 Compare October 5, 2026 04:24
@rohanKanojia rohanKanojia changed the title chore (deps) : update controller-runtime to v0.25.1 chore(deps): update controller-runtime to v0.25.2 Oct 5, 2026
@rohanKanojia
rohanKanojia force-pushed the pr/chore-update-controller-runtime branch from 0e5da26 to e59ec17 Compare October 5, 2026 04:40
…date

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@rohanKanojia
rohanKanojia force-pushed the pr/chore-update-controller-runtime branch from e59ec17 to e044cbf Compare October 5, 2026 05:04
Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@rohanKanojia
rohanKanojia force-pushed the pr/chore-update-controller-runtime branch from ab8333f to c08669b Compare October 7, 2026 07:30
@codecov

codecov Bot commented Oct 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.84%. Comparing base (3526ad3) to head (c08669b).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1706      +/-   ##
==========================================
+ Coverage   40.45%   40.84%   +0.39%     
==========================================
  Files         174      176       +2     
  Lines       15949    13147    -2802     
==========================================
- Hits         6452     5370    -1082     
+ Misses       9096     7355    -1741     
- Partials      401      422      +21     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant