Skip to content

feat(cli): default MiniMax presets to M3.1 Flash - #963

Open
octo-patch wants to merge 1 commit into
devswha:mainfrom
octo-patch:octo/minimax-m31-flash
Open

octo-patch wants to merge 1 commit into
devswha:mainfrom
octo-patch:octo/minimax-m31-flash

Conversation

@octo-patch

@octo-patch octo-patch commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Reason: The MiniMax regional presets still default to MiniMax-M3, while the current MiniMax API documentation recommends MiniMax-M3.1-Flash.

Changes

  • Default --provider minimax and --provider minimax-cn to MiniMax-M3.1-Flash and update the environment example.
  • Preserve explicit --model / saved configuration values, including MiniMax-M3, legacy IDs, and custom IDs; regional endpoints and resolution precedence stay unchanged.
  • Add coverage for both regional defaults, existing environment precedence, and buffered/streaming request serialization.

References: global API model documentation, China API model documentation.

Verification

  • Node 24.21.0: node --test tests/e2e/providers.test.js — 14 passed with an empty credential environment.
  • Focused provider/backend tests plus an external offline request-boundary fixture — 47 passed. The fixture exercised 30 production callLLM fetch boundaries, including both regions, saved YAML configuration, M3, legacy/custom model IDs, and buffered/streaming requests. Fetch was mocked; no paid inference or external provider requests were made.
  • The backend/request checks reused an existing read-only js-yaml 4.3.2 module matching package-lock.json, via a test-only module resolution hook. No dependencies were installed and no lockfile changed.
  • node scripts/lint.mjs — syntax OK for all 352 JavaScript files; git diff --check passed.
  • Full npm test, ESLint/type checks, browser checks, and live provider inference were not run locally. This checkout has no installed dependencies and new installation/build work is paused by the execution environment's resource constraints.
  • Exact-head GitHub Actions passed all eight jobs at 84e229245c2ac32b4ca10c6d077455a4b2a64d8a: lint, quality, browser, release-install, and tests on Node 18.1.0, 20, 22, and lts/*. CodeRabbit completed successfully. The separate Vercel status requires deployment authorization.

@vercel

vercel Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

@octo-patch is attempting to deploy a commit to the devshwa's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: devswha/patina/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 98426519-4897-4e02-8c26-f3369b9e676f
📥 Commits

Reviewing files that changed from the base of the PR and between 9ad44bc and 84e2292.

📒 Files selected for processing: 3
  • .env.example
  • src/providers.js
  • tests/e2e/providers.test.js

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

📝 Summary

Summary by CodeRabbit

  • 변경 사항
    • MiniMax 글로벌 및 중국 리전의 기본 모델이 MiniMax-M3.1-Flash로 변경되었습니다.
    • 기존 MiniMax-M3 모델을 명시적으로 선택하는 기능은 계속 지원됩니다.
    • MiniMax 요청 처리와 모델 선택 우선순위가 다양한 설정에서 검증되었습니다.

MiniMax 글로벌 및 중국 리전 프리셋의 기본 모델을 MiniMax-M3.1-Flash로 변경했습니다. 환경 변수 주석과 E2E 테스트도 새 기본값에 맞게 갱신하고 모델 선택 및 요청 직렬화를 검증합니다.

Changes: MiniMax 모델 기본값

Layer / File(s) Summary
MiniMax 기본 모델 변경
.env.example, src/providers.js
두 MiniMax 프리셋의 기본 모델을 MiniMax-M3.1-Flash로 변경했습니다. 환경 변수 주석에는 명시적 M3 지원 문구를 추가했습니다.
모델 선택 및 요청 직렬화 검증
tests/e2e/providers.test.js
기본 모델, 명시적 모델 플래그, PATINA_MODEL 우선순위, 채팅 완료 요청의 모델·메시지·스트리밍 설정을 검증합니다. 요청에서 추론 관련 필드가 제외되는지도 확인합니다.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Suggested reviewers: devswha

Merge Risk: ⚪ Minimal · up to 84e22

This changes the default MiniMax model for the global and China presets to MiniMax-M3.1-Flash. Explicit model choices are unaffected, and tests cover the new defaults and request serialization. No concrete merge-blocking risk was established.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed 제목은 MiniMax 프리셋의 기본 모델을 MiniMax-M3.1-Flash로 변경하는 주요 변경 사항을 정확하고 간결하게 설명합니다.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed PR 설명은 MiniMax 기본 모델 변경, 환경 예제 갱신, 명시적 모델 설정 유지, 테스트 범위를 구체적으로 설명합니다. 변경 사항과 직접 관련되어 있습니다.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant