Skip to content

SMT2: define is_dynamic_object once all objects are known - #9228

Open
tautschnig wants to merge 1 commit into
diffblue:developfrom
tautschnig:kiro/9207-is-dynamic-object
Open

tautschnig wants to merge 1 commit into
diffblue:developfrom
tautschnig:kiro/9207-is-dynamic-object

Conversation

@tautschnig

Copy link
Copy Markdown
Collaborator

convert_is_dynamic_object consulted the set of dynamic objects at the
point the expression was converted, so it only knew the dynamic objects
whose addresses had been converted before. For a pointer queried before
a malloc, is_dynamic_object was false even when the pointer could
alias the newly allocated object, so CBMC could prove assertions that
fail.

Follow the pattern used for object_size: declare an auxiliary Boolean
symbol in find_symbols, use it where the expression occurs, and define
it in write_footer, where all objects are known. The definition binds
the object part of the pointer once and states, for each known object,
whether the symbol is true or false when the pointer refers to it.
Object numbers that do not belong to any known object are left
unconstrained, as in the propositional back-end.

Fixes #9207

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

convert_is_dynamic_object consulted the set of dynamic objects at the
point the expression was converted, so it only knew the dynamic objects
whose addresses had been converted before. For a pointer queried before
a malloc, is_dynamic_object was false even when the pointer could
alias the newly allocated object, so CBMC could prove assertions that
fail.

Follow the pattern used for object_size: declare an auxiliary Boolean
symbol in find_symbols, use it where the expression occurs, and define
it in write_footer, where all objects are known. The definition binds
the object part of the pointer once and states, for each known object,
whether the symbol is true or false when the pointer refers to it.
Object numbers that do not belong to any known object are left
unconstrained, as in the propositional back-end.

Fixes diffblue#9207

Co-authored-by: Kiro <kiro-agent@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 20, 2026 19:39

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

@codecov

codecov Bot commented Oct 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.90%. Comparing base (266f438) to head (5437afd).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9228      +/-   ##
===========================================
- Coverage    80.91%   80.90%   -0.02%     
===========================================
  Files         1718     1718              
  Lines       190266   190277      +11     
  Branches        73       73              
===========================================
- Hits        153952   153941      -11     
- Misses       36314    36336      +22     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SMT2 backend: is_dynamic_object only knows objects seen so far and is false for all others

2 participants