Repository navigation
SMT2: define is_dynamic_object once all objects are known - #9228
Open
tautschnig wants to merge 1 commit into
Open
tautschnig wants to merge 1 commit into
tautschnig wants to merge 1 commit into
Conversation
convert_is_dynamic_object consulted the set of dynamic objects at the point the expression was converted, so it only knew the dynamic objects whose addresses had been converted before. For a pointer queried before a malloc, is_dynamic_object was false even when the pointer could alias the newly allocated object, so CBMC could prove assertions that fail. Follow the pattern used for object_size: declare an auxiliary Boolean symbol in find_symbols, use it where the expression occurs, and define it in write_footer, where all objects are known. The definition binds the object part of the pointer once and states, for each known object, whether the symbol is true or false when the pointer refers to it. Object numbers that do not belong to any known object are left unconstrained, as in the propositional back-end. Fixes diffblue#9207 Co-authored-by: Kiro <kiro-agent@users.noreply.github.com>
tautschnig
requested review from
TGWDB,
kroening,
martin-cs and
peterschrammel
as code owners
October 20, 2026 19:39
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #9228 +/- ##
===========================================
- Coverage 80.91% 80.90% -0.02%
===========================================
Files 1718 1718
Lines 190266 190277 +11
Branches 73 73
===========================================
- Hits 153952 153941 -11
- Misses 36314 36336 +22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
convert_is_dynamic_object consulted the set of dynamic objects at the
point the expression was converted, so it only knew the dynamic objects
whose addresses had been converted before. For a pointer queried before
a malloc, is_dynamic_object was false even when the pointer could
alias the newly allocated object, so CBMC could prove assertions that
fail.
Follow the pattern used for object_size: declare an auxiliary Boolean
symbol in find_symbols, use it where the expression occurs, and define
it in write_footer, where all objects are known. The definition binds
the object part of the pointer once and states, for each known object,
whether the symbol is true or false when the pointer refers to it.
Object numbers that do not belong to any known object are left
unconstrained, as in the propositional back-end.
Fixes #9207