Repository navigation
fix(setup): polish Files selection bars and locked actions - #63
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trash selections were rendered into a grid intended for different child elements: the count wrapped in a 24px track and Restore overflowed its button. Files and Trash now share one keyed selection renderer with named summary/action groups that wrap together. The reproduced desktop Trash bar is 45px tall instead of 129px.
Managed and read-only menus now visibly mute unavailable actions, including destructive actions, and explain the restriction. Shared Kit menus expose native and ARIA disabled states, skip unavailable items during initial/arrow-key focus, and ignore disabled child clicks. Phone bulk actions and keyboard commands respect the same lock; explicit unlock/relock still controls editing.
Phone selection uses Kit's icon-and-label action bar with safe-area padding, touch targets of at least 44px, and Undo notifications above it. Trash offers Restore/Remove rather than editing/transfer commands. Long phone menus scroll their actions while keeping the heading, explanation and Cancel visible.
Validation
Native AMD64/ARM64 image checks run on this PR.
Screenshots
Synthetic fixture data, captured from this branch.
Trash selection · dark
Managed actions · light