Skip to content

fix(setup): polish Files selection bars and locked actions - #63

Merged
dizys merged 1 commit into
mainfrom
fix/files-action-states
Oct 25, 2026
Merged

dizys merged 1 commit into
mainfrom
fix/files-action-states

Conversation

@dizys

@dizys dizys commented Oct 25, 2026

Copy link
Copy Markdown
Owner

Trash selections were rendered into a grid intended for different child elements: the count wrapped in a 24px track and Restore overflowed its button. Files and Trash now share one keyed selection renderer with named summary/action groups that wrap together. The reproduced desktop Trash bar is 45px tall instead of 129px.

Managed and read-only menus now visibly mute unavailable actions, including destructive actions, and explain the restriction. Shared Kit menus expose native and ARIA disabled states, skip unavailable items during initial/arrow-key focus, and ignore disabled child clicks. Phone bulk actions and keyboard commands respect the same lock; explicit unlock/relock still controls editing.

Phone selection uses Kit's icon-and-label action bar with safe-area padding, touch targets of at least 44px, and Undo notifications above it. Trash offers Restore/Remove rather than editing/transfer commands. Long phone menus scroll their actions while keeping the heading, explanation and Cancel visible.

Validation

  • 903/903 Node tests; syntax, whitespace and harness checks passed.
  • Files Browse: 12 light/dark configurations, 84 layout checks.
  • Files Change: 16 configurations, 112 layout checks, plus a final 6-case phone/narrow/embedded-phone pass after the touch/menu refinements.
  • Files Space/archives: 14 configurations, 244 checks.
  • New regressions exercise real text/button bounds, synchronized selection, touch targets, disabled styles/ARIA, synthetic child clicks, keyboard focus, no-write locked shortcuts, unlock/edit/relock, read-only menus and Trash review/restore.
  • Native preview comparisons covered light/dark desktop and 320px/390px phones. Existing server-side authorization and deletion reviews remain in force. All browser mutations use isolated fixtures.

Native AMD64/ARM64 image checks run on this PR.

Screenshots

Synthetic fixture data, captured from this branch.

Trash selection · dark

Compact Trash selection toolbar with aligned summary, Restore and Remove actions

Managed actions · light

Managed file menu with visibly disabled editing and deletion actions, active read actions and an explanation

Phone Trash selection Phone managed actions
Phone Trash selection with large Restore and Remove actions and a separate Done control Dark phone menu with muted disabled actions and a visible lock explanation and Cancel

@dizys
dizys merged commit 9fa256a into main Oct 25, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant