fix: clarify speech input requirements - #4498
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused documentation, diagnostics, and regression tests consistently reflect the existing transcription architecture.
Review effort: Balanced
Findings: None
What changed in this PR
Clarifies /speak requirements and improves diagnostics for direct OpenAI Realtime transcription.
Changes:
- Documents macOS, API-key, and gateway limitations.
- Improves command help and connection errors.
- Adds regression tests for help text and startup failures.
| File | Description |
|---|---|
pkg/tui/commands/defaults/speak_darwin.go |
Clarifies command requirements. |
pkg/tui/commands/defaults/speak_darwin_test.go |
Tests command help text. |
pkg/audio/transcribe/transcribe_darwin.go |
Improves startup and connection errors. |
pkg/audio/transcribe/transcribe_darwin_test.go |
Tests transcription failure paths. |
docs/features/tui/index.md |
Documents /speak setup and behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
aheritier
enabled auto-merge
October 1, 2026 21:30
trungutt
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify that /speak transcribes audio directly through OpenAI Realtime and requires OPENAI_API_KEY, independent of the chat provider. Document that Docker models gateway does not support /speak, and improve command help and startup/connection errors. Add regression tests for command help and transcription failures.
Validation reported: build, focused tests, and focused lint passed. The full test suite encountered an ACP usage test failure; full lint reported three findings outside the changed files. The Docker connection test passed on rerun.