Conversation
This comment was marked as spam.
This comment was marked as spam.
crazy-max
force-pushed
the
bake-vars
branch
2 times, most recently
from
October 5, 2026 13:18
390133a to
24c9901
Compare
crazy-max
marked this pull request as ready for review
October 5, 2026 13:20
Disable Bake environment variable lookup so workflow and runner environment values do not implicitly override Bake variables. Forward only GITHUB_ and RUNNER_ prefixed values as explicit Bake vars, then pass the caller vars input through docker/bake-action. Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
needs #248Disable ambient Bake variable lookup so workflow and runner environment values cannot implicitly override the Bake definition. Pass caller-provided variables explicitly to both definition validation and
docker/bake-action.Use the
BakeVarshelper to forwardCIand anyGITHUB_orRUNNER_variables, with caller-provided values taking precedence. The workflow fixture verifies that these values resolve while unrelated environment variables stay excluded.