Repository navigation
Update tests for Azure SQL - #39360
Open
AndriySvyryd wants to merge 1 commit into
Open
AndriySvyryd wants to merge 1 commit into
AndriySvyryd wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Empty supported elastic pools are incorrectly cached as unsupported, silently skipping memory-optimized tests.
1 open issue
What changed in this PR
Updates EF Core’s SQL Server functional tests to account for Azure SQL configuration and JSON behavior.
Changes:
- Adjusts JSON query, update, and migration expectations for Azure SQL.
- Preserves provider configuration when customizing test options.
- Updates capability detection and elastic-pool test conditions.
| File | Description |
|---|---|
| test/EFCore.SqlServer.FunctionalTests/Update/JsonUpdateSqlServerTest.cs | Adds Azure-specific parameter baselines. |
| test/EFCore.SqlServer.FunctionalTests/Update/JsonUpdateJsonTypeSqlServerTest.cs | Adjusts Azure parameter-size expectations. |
| test/EFCore.SqlServer.FunctionalTests/Types/SqlServerTypeFixture.cs | Uses JSON capability detection. |
| test/EFCore.SqlServer.FunctionalTests/Types/SqlServerSpatialTypeTestBase.cs | Preserves provider selection when configuring spatial support. |
| test/EFCore.SqlServer.FunctionalTests/TransactionSqlServerTest.cs | Selects Azure SQL configuration when appropriate. |
| test/EFCore.SqlServer.FunctionalTests/TestUtilities/SqlServerTestEnvironment.cs | Updates capability and compatibility detection. |
| test/EFCore.SqlServer.FunctionalTests/SqlServerValueGenerationConflictTest.cs | Configures contexts for the selected provider. |
| test/EFCore.SqlServer.FunctionalTests/SqlAzure/SqlAzureDatabaseCreationTest.cs | Gates pool tests and corrects tier configuration. |
| test/EFCore.SqlServer.FunctionalTests/Query/JsonQueryJsonTypeSqlServerTest.cs | Corrects JSON query baselines. |
| test/EFCore.SqlServer.FunctionalTests/Query/Inheritance/TPTInheritanceJsonQuerySqlServerTest.cs | Adds Azure-specific inheritance query expectations. |
| test/EFCore.SqlServer.FunctionalTests/Query/Inheritance/TPHInheritanceJsonQuerySqlServerTest.cs | Adds Azure-specific inheritance query expectations. |
| test/EFCore.SqlServer.FunctionalTests/Query/Inheritance/TPCInheritanceJsonQuerySqlServerTest.cs | Adds Azure-specific inheritance query expectations. |
| test/EFCore.SqlServer.FunctionalTests/Query/ComplexTypeQuerySqlServerTest.cs | Explicitly maps string lists to text columns. |
| test/EFCore.SqlServer.FunctionalTests/Query/Associations/OwnedJson/OwnedJsonSqlServerFixture.cs | Recognizes Azure JSON support. |
| test/EFCore.SqlServer.FunctionalTests/Query/Associations/OwnedJson/OwnedJsonProjectionSqlServerTest.cs | Selects Azure-compatible projection baselines. |
| test/EFCore.SqlServer.FunctionalTests/Query/Associations/OwnedJson/OwnedJsonCollectionSqlServerTest.cs | Adjusts Azure collection expectations. |
| test/EFCore.SqlServer.FunctionalTests/Query/Associations/ComplexJson/ComplexJsonStructuralEqualitySqlServerTest.cs | Adjusts nested JSON column types in baselines. |
| test/EFCore.SqlServer.FunctionalTests/Query/Associations/ComplexJson/ComplexJsonSqlServerFixture.cs | Recognizes Azure JSON support. |
| test/EFCore.SqlServer.FunctionalTests/Query/Associations/ComplexJson/ComplexJsonSetOperationsSqlServerTest.cs | Selects Azure-compatible aggregate expectations. |
| test/EFCore.SqlServer.FunctionalTests/Query/Associations/ComplexJson/ComplexJsonProjectionSqlServerTest.cs | Selects Azure-compatible projection baselines. |
| test/EFCore.SqlServer.FunctionalTests/Query/Associations/ComplexJson/ComplexJsonCollectionSqlServerTest.cs | Adjusts Azure collection expectations. |
| test/EFCore.SqlServer.FunctionalTests/Migrations/MigrationsSqlServerTest.cs | Expects Azure’s native JSON column type. |
| test/EFCore.SqlServer.FunctionalTests/KeysWithConvertersSqlServerTest.cs | Preserves provider selection when configuring batching. |
| test/EFCore.Relational.Specification.Tests/Migrations/MigrationsTestBase.cs | Preserves string storage types in conversion tests. |
Review effort: Balanced
Code coverage overviewLanguages: C# C# / code-coverage
View coverage of the 10 most impacted files.
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. Updated |
AndriySvyryd
force-pushed
the
AzureTests
branch
from
October 21, 2026 21:35
4bf6361 to
e9207aa
Compare
AndriySvyryd
marked this pull request as ready for review
October 21, 2026 22:28
Comment on lines
+245
to
+246
| await using var testStore = SqlServerTestStore.Create( | ||
| $"MemoryOptimizedTablesProbe_{Guid.NewGuid():N}"); |
AndriySvyryd
force-pushed
the
AzureTests
branch
from
October 22, 2026 01:16
e9207aa to
5a9d33e
Compare
| SELECT [o0].[c] | ||
| FROM ( | ||
| SELECT JSON_VALUE([o].[OwnedReferenceLeaf], '$.SomethingSomething' RETURNING nvarchar(max)) AS [c], [o].[Date] | ||
| SELECT JSON_VALUE([o].[OwnedReferenceLeaf], '$.SomethingSomething') AS [c], [o].[Date] |
Comment on lines
+251
to
+254
| IF SERVERPROPERTY('EngineEdition') <> 5 | ||
| BEGIN | ||
| ALTER DATABASE [{0}] SET SINGLE_USER WITH ROLLBACK IMMEDIATE; | ||
| END; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.